d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

GHA: Add additional checks for common issues (#1922)

Browse Source 
* GHA, tests: Add additional checks for common issues

These checks include:
- Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`).
- Replacing `%s` with %q
- Enforcing consistent usage of should/must wording for testify assert/require messages

* Add support for checking backticked string format specifiers and fix issues

* tests: Fix error comparisons

* tests: Replace errors.Is(err, nil) usage with testify and automate check

* refactor: Rename ExtractPort to ExtractPortOrDefault

* tests: Replace assert with require for error handling in multiple test files

* tests: Replace assert with require for error handling and improve assertions in data tests

* tests: Fix typo in assertion message for StreamVol test

* OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions

* OKX: Revert intentional error check

* Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
This commit is contained in:
Adrian Gallagher
2025-05-28 12:26:51 +10:00
committed by GitHub
parent 1e5739dffa
commit a5b638bfb7
165 changed files with 2565 additions and 4626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
log/logger_test.go
View File

@@ -10,6 +10,7 @@ import (
"time"
"github.com/gofrs/uuid"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/common/convert"
"github.com/thrasher-corp/gocryptotrader/encoding/json"
)
@@ -105,9 +106,7 @@ func TestSetGlobalLogConfig(t *testing.T) {
t.Fatalf("received: '%v' but expected: '%v'", err, errConfigNil)
}
err = SetGlobalLogConfig(testConfigEnabled)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestSetLogPath(t *testing.T) {
@@ -118,9 +117,7 @@ func TestSetLogPath(t *testing.T) {
}
err = SetLogPath(tempDir)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
if path := GetLogPath(); path != tempDir {
t.Fatalf("received: '%v' but expected: '%v'", path, tempDir)
@@ -155,9 +152,8 @@ func TestAddWriter(t *testing.T) {
}
mw, err := multiWriter()
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
err = mw.add(io.Discard)
if err != nil {
t.Fatal(err)
@@ -248,9 +244,8 @@ func TestGetWriters(t *testing.T) {
}
fileLoggingConfiguredCorrectly = true
_, err = getWriters(&SubLoggerConfig{Output: outputWriters})
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
mu.Unlock()
outputWriters = "stdout|stderr|noobs"
@@ -589,9 +584,7 @@ func TestNewSubLogger(t *testing.T) {
}
sl, err := NewSubLogger("TESTERINOS")
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
Debugln(sl, "testerinos")
@@ -620,21 +613,15 @@ func TestRotateWrite(t *testing.T) {
// test write
payload = make([]byte, 1*megabyte-1)
_, err = empty.Write(payload)
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
// test rotate
payload = make([]byte, 1*megabyte)
_, err = empty.Write(payload)
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
err = empty.Close()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
}
func TestOpenNew(t *testing.T) {
@@ -647,14 +634,10 @@ func TestOpenNew(t *testing.T) {
empty.FileName = "wow.txt"
err = empty.openNew()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
err = empty.Close()
if !errors.Is(err, nil) {
t.Fatalf("received: %v but expected: %v", err, nil)
}
require.NoError(t, err)
}
type testBuffer struct {