d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

GHA: Add additional checks for common issues (#1922)

Browse Source 
* GHA, tests: Add additional checks for common issues

These checks include:
- Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`).
- Replacing `%s` with %q
- Enforcing consistent usage of should/must wording for testify assert/require messages

* Add support for checking backticked string format specifiers and fix issues

* tests: Fix error comparisons

* tests: Replace errors.Is(err, nil) usage with testify and automate check

* refactor: Rename ExtractPort to ExtractPortOrDefault

* tests: Replace assert with require for error handling in multiple test files

* tests: Replace assert with require for error handling and improve assertions in data tests

* tests: Fix typo in assertion message for StreamVol test

* OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions

* OKX: Revert intentional error check

* Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
This commit is contained in:
Adrian Gallagher
2025-05-28 12:26:51 +10:00
committed by GitHub
parent 1e5739dffa
commit a5b638bfb7
165 changed files with 2565 additions and 4626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
exchanges/kline/technical_analysis_test.go
View File

@@ -3,6 +3,8 @@ package kline
import (
"errors"
"testing"
"github.com/stretchr/testify/require"
)
func TestGetOHLC(t *testing.T) {
@@ -51,15 +53,11 @@ func TestGetAverageTrueRange(t *testing.T) {
}
_, err = ohlc.GetAverageTrueRange(1)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{High: 1337, Low: 1337, Close: 1337}}}
_, err = wrap.GetAverageTrueRange(1)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetBollingerBands(t *testing.T) {
@@ -99,15 +97,11 @@ func TestGetBollingerBands(t *testing.T) {
}
_, err = ohlc.GetBollingerBands(9, 1, 1, 5)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}}}
_, err = wrap.GetBollingerBands(9, 1, 1, 5)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetCorrelationCoefficient(t *testing.T) {
@@ -159,15 +153,11 @@ func TestGetCorrelationCoefficient(t *testing.T) {
}
_, err = ohlc.GetCorrelationCoefficient(&OHLC{Close: []float64{1337, 1337, 1337}}, 2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}}}
_, err = wrap.GetCorrelationCoefficient(&Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}}}, 2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetSimpleMovingAverage(t *testing.T) {
@@ -196,15 +186,11 @@ func TestGetSimpleMovingAverage(t *testing.T) {
}
_, err = ohlc.GetSimpleMovingAverage([]float64{1337, 1337}, 2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}}}
_, err = wrap.GetSimpleMovingAverageOnClose(2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetExponentialMovingAverage(t *testing.T) {
@@ -233,15 +219,11 @@ func TestGetExponentialMovingAverage(t *testing.T) {
}
_, err = ohlc.GetExponentialMovingAverage([]float64{1337, 1337, 1337}, 2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}}}
_, err = wrap.GetExponentialMovingAverageOnClose(2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetMovingAverageConvergenceDivergence(t *testing.T) {
@@ -285,15 +267,11 @@ func TestGetMovingAverageConvergenceDivergence(t *testing.T) {
}
_, err = ohlc.GetMovingAverageConvergenceDivergence([]float64{1337, 1337, 1337, 1337, 1337, 1337, 1337, 1337}, 1, 2, 1)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}, {Close: 1337}}}
_, err = wrap.GetMovingAverageConvergenceDivergenceOnClose(1, 2, 1)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetMoneyFlowIndex(t *testing.T) {
@@ -347,9 +325,7 @@ func TestGetMoneyFlowIndex(t *testing.T) {
}
_, err = ohlc.GetMoneyFlowIndex(3)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{
{Close: 1337, High: 1337, Low: 1337, Volume: 1337},
@@ -357,9 +333,7 @@ func TestGetMoneyFlowIndex(t *testing.T) {
{Close: 1337, High: 1337, Low: 1337, Volume: 1337},
}}
_, err = wrap.GetMoneyFlowIndex(2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetOnBalanceVolume(t *testing.T) {
@@ -385,15 +359,11 @@ func TestGetOnBalanceVolume(t *testing.T) {
ohlc.Volume = append(ohlc.Volume, 0.00000001)
_, err = ohlc.GetOnBalanceVolume()
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
wrap := Item{Candles: []Candle{{Close: 1337, Volume: 1337}}}
_, err = wrap.GetOnBalanceVolume()
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}
func TestGetRelativeStrengthIndex(t *testing.T) {
@@ -423,7 +393,5 @@ func TestGetRelativeStrengthIndex(t *testing.T) {
wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}}}
_, err = wrap.GetRelativeStrengthIndexOnClose(2)
if !errors.Is(err, nil) {
t.Fatalf("received: '%v' but expected: '%v'", err, nil)
}
require.NoError(t, err)
}