mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-06-04 23:16:54 +00:00
GHA: Add additional checks for common issues (#1922)
* GHA, tests: Add additional checks for common issues These checks include: - Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`). - Replacing `%s` with %q - Enforcing consistent usage of should/must wording for testify assert/require messages * Add support for checking backticked string format specifiers and fix issues * tests: Fix error comparisons * tests: Replace errors.Is(err, nil) usage with testify and automate check * refactor: Rename ExtractPort to ExtractPortOrDefault * tests: Replace assert with require for error handling in multiple test files * tests: Replace assert with require for error handling and improve assertions in data tests * tests: Fix typo in assertion message for StreamVol test * OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions * OKX: Revert intentional error check * Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
This commit is contained in:
@@ -48,9 +48,8 @@ func TestGetCredentials(t *testing.T) {
|
||||
Secret: "aGVsbG8gd29ybGQ=",
|
||||
})
|
||||
creds, err := b.GetCredentials(ctx)
|
||||
if !errors.Is(err, nil) {
|
||||
t.Fatalf("received: %v but expected: %v", err, nil)
|
||||
}
|
||||
require.NoError(t, err)
|
||||
|
||||
if creds.Secret != expectedBase64DecodedOutput {
|
||||
t.Fatalf("received: %v but expected: %v", creds.Secret, expectedBase64DecodedOutput)
|
||||
}
|
||||
@@ -71,9 +70,7 @@ func TestGetCredentials(t *testing.T) {
|
||||
|
||||
ctx = account.DeployCredentialsToContext(t.Context(), fullCred)
|
||||
creds, err = b.GetCredentials(ctx)
|
||||
if !errors.Is(err, nil) {
|
||||
t.Fatalf("received: %v but expected: %v", err, nil)
|
||||
}
|
||||
require.NoError(t, err)
|
||||
|
||||
if creds.Key != "superkey" &&
|
||||
creds.Secret != "supersecret" &&
|
||||
@@ -105,9 +102,7 @@ func TestGetCredentials(t *testing.T) {
|
||||
|
||||
ctx = context.WithValue(t.Context(), account.ContextSubAccountFlag, "superaccount")
|
||||
overridedSA, err := b.GetCredentials(ctx)
|
||||
if !errors.Is(err, nil) {
|
||||
t.Fatalf("received: %v but expected: %v", err, nil)
|
||||
}
|
||||
require.NoError(t, err)
|
||||
|
||||
if overridedSA.Key != "hello" &&
|
||||
overridedSA.Secret != "sir" &&
|
||||
@@ -117,9 +112,7 @@ func TestGetCredentials(t *testing.T) {
|
||||
}
|
||||
|
||||
notOverrided, err := b.GetCredentials(t.Context())
|
||||
if !errors.Is(err, nil) {
|
||||
t.Fatalf("received: %v but expected: %v", err, nil)
|
||||
}
|
||||
require.NoError(t, err)
|
||||
|
||||
if notOverrided.Key != "hello" &&
|
||||
notOverrided.Secret != "sir" &&
|
||||
|
||||
Reference in New Issue
Block a user