mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-06-01 23:16:51 +00:00
GHA: Add additional checks for common issues (#1922)
* GHA, tests: Add additional checks for common issues These checks include: - Ensuring that all testify funcs use their formatted variants (e.g., `assert.Equalf(t, expected, actual)` instead of `assert.Equal(t, expected, actual)`). - Replacing `%s` with %q - Enforcing consistent usage of should/must wording for testify assert/require messages * Add support for checking backticked string format specifiers and fix issues * tests: Fix error comparisons * tests: Replace errors.Is(err, nil) usage with testify and automate check * refactor: Rename ExtractPort to ExtractPortOrDefault * tests: Replace assert with require for error handling in multiple test files * tests: Replace assert with require for error handling and improve assertions in data tests * tests: Fix typo in assertion message for StreamVol test * OKX: Fix GetOpenInterestAndVolumeStrike test with instrument selection and improved assertions * OKX: Revert intentional error check * Improve error message for expiry time check in GetOpenInterestAndVolumeStrike test
This commit is contained in:
@@ -4,6 +4,7 @@ import (
|
||||
"errors"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"github.com/thrasher-corp/gocryptotrader/encoding/json"
|
||||
)
|
||||
@@ -640,11 +641,7 @@ func TestItemString(t *testing.T) {
|
||||
AssocChain: "Silly",
|
||||
}
|
||||
|
||||
if expected := "HWORLD"; newItem.String() != expected {
|
||||
t.Errorf("Currency String() error expected '%s' but received '%s'",
|
||||
expected,
|
||||
&newItem)
|
||||
}
|
||||
assert.Equal(t, "HWORLD", newItem.String())
|
||||
}
|
||||
|
||||
// 28848025 40.84 ns/op 8 B/op 1 allocs/op // Current
|
||||
|
||||
Reference in New Issue
Block a user