d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

exchanges: Refactor UpdateTradablePairs method to remove forceUpdate parameter (#2043)

Browse Source 
* Refactor UpdateTradablePairs method to remove forceUpdate parameter

- Updated the signature of UpdateTradablePairs in multiple exchange wrappers to remove the forceUpdate boolean parameter.
- Adjusted related test cases to reflect the change in method signature.
- Ensured that the UpdatePairs method calls within UpdateTradablePairs no longer reference the removed parameter.

* update exchange wrapper template

* linter: fix

* glorious: nits

* thrasher/glorious: nits

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* fix things

* misc: fix

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
This commit is contained in:
Ryan O'Hara-Reid
2025-09-22 12:20:23 +10:00
committed by GitHub
parent b4a272de02
commit 9f8b783c20
46 changed files with 179 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
exchanges/bitstamp/bitstamp_test.go
View File

@@ -235,7 +235,7 @@ func TestFetchTradablePairs(t *testing.T) {
func TestUpdateTradablePairs(t *testing.T) {
t.Parallel()
err := e.UpdateTradablePairs(t.Context(), true)
err := e.UpdateTradablePairs(t.Context())
require.NoError(t, err, "UpdateTradablePairs must not error")
}

5
exchanges/bitstamp/bitstamp_wrapper.go
View File

@@ -196,13 +196,12 @@ func (e *Exchange) FetchTradablePairs(ctx context.Context, _ asset.Item) (curren
// UpdateTradablePairs updates the exchanges available pairs and stores
// them in the exchanges config
func (e *Exchange) UpdateTradablePairs(ctx context.Context, forceUpdate bool) error {
func (e *Exchange) UpdateTradablePairs(ctx context.Context) error {
pairs, err := e.FetchTradablePairs(ctx, asset.Spot)
if err != nil {
return err
}
err = e.UpdatePairs(pairs, asset.Spot, false, forceUpdate)
if err != nil {
if err := e.UpdatePairs(pairs, asset.Spot, false); err != nil {
return err
}
return e.EnsureOnePairEnabled()