d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

exchanges: Refactor UpdateTradablePairs method to remove forceUpdate parameter (#2043)

Browse Source 
* Refactor UpdateTradablePairs method to remove forceUpdate parameter

- Updated the signature of UpdateTradablePairs in multiple exchange wrappers to remove the forceUpdate boolean parameter.
- Adjusted related test cases to reflect the change in method signature.
- Ensured that the UpdatePairs method calls within UpdateTradablePairs no longer reference the removed parameter.

* update exchange wrapper template

* linter: fix

* glorious: nits

* thrasher/glorious: nits

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

* fix things

* misc: fix

* Update exchanges/exchange_test.go

Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>

---------

Co-authored-by: shazbert <ryan.oharareid@thrasher.io>
Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
This commit is contained in:
Ryan O'Hara-Reid
2025-09-22 12:20:23 +10:00
committed by GitHub
parent b4a272de02
commit 9f8b783c20
46 changed files with 179 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
exchanges/binance/binance_live_test.go
View File

@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
}
e.Websocket.DataHandler = sharedtestvalues.GetWebsocketInterfaceChannelOverride()
log.Printf(sharedtestvalues.LiveTesting, e.Name)
if err := e.UpdateTradablePairs(context.Background(), true); err != nil {
if err := e.UpdateTradablePairs(context.Background()); err != nil {
log.Fatalf("Binance UpdateTradablePairs error: %s", err)
}
os.Exit(m.Run())

2
exchanges/binance/binance_mock_test.go
View File

@@ -28,7 +28,7 @@ func TestMain(m *testing.M) {
if err := testexch.MockHTTPInstance(e); err != nil {
log.Fatalf("Binance MockHTTPInstance error: %s", err)
}
if err := e.UpdateTradablePairs(context.Background(), true); err != nil {
if err := e.UpdateTradablePairs(context.Background()); err != nil {
log.Fatalf("Binance UpdateTradablePairs error: %s", err)
}
os.Exit(m.Run())

6
exchanges/binance/binance_wrapper.go
View File

@@ -318,16 +318,14 @@ func (e *Exchange) FetchTradablePairs(ctx context.Context, a asset.Item) (curren
// UpdateTradablePairs updates the exchanges available pairs and stores
// them in the exchanges config
func (e *Exchange) UpdateTradablePairs(ctx context.Context, forceUpdate bool) error {
func (e *Exchange) UpdateTradablePairs(ctx context.Context) error {
assetTypes := e.GetAssetTypes(false)
for i := range assetTypes {
pairs, err := e.FetchTradablePairs(ctx, assetTypes[i])
if err != nil {
return err
}
err = e.UpdatePairs(pairs, assetTypes[i], false, forceUpdate)
if err != nil {
if err := e.UpdatePairs(pairs, assetTypes[i], false); err != nil {
return err
}
}