From 99e8d2f1677ac8c88bf33537b730b8c81592c3d1 Mon Sep 17 00:00:00 2001 From: Harry Ma Date: Sat, 14 Mar 2020 10:02:27 +0800 Subject: [PATCH] (BUG FIX) Fix order submission crash due to missing "exchange" parameter (#468) * fix the return problem * fix the return problem * add the mandatory parameter * fix the symbol empity problem * fix the symbol empty problem * add Pair parameter for order.Cancel parameters * follow the gofmt rule Co-authored-by: MK --- engine/rpcserver.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/engine/rpcserver.go b/engine/rpcserver.go index aaeba1d8..78ea92e6 100644 --- a/engine/rpcserver.go +++ b/engine/rpcserver.go @@ -804,7 +804,13 @@ func (s *RPCServer) SubmitOrder(ctx context.Context, r *gctrpc.SubmitOrderReques Amount: r.Amount, Price: r.Price, ClientID: r.ClientId, + Exchange: r.Exchange, }) + + if err != nil { + return &gctrpc.SubmitOrderResponse{}, err + } + return &gctrpc.SubmitOrderResponse{ OrderId: resp.OrderID, OrderPlaced: resp.IsOrderPlaced, @@ -898,6 +904,7 @@ func (s *RPCServer) CancelOrder(ctx context.Context, r *gctrpc.CancelOrderReques ID: r.OrderId, Side: order.Side(r.Side), WalletAddress: r.WalletAddress, + Pair: currency.NewPairFromStrings(r.Pair.Base, r.Pair.Quote), }) return &gctrpc.CancelOrderResponse{}, err