From 86e091028fc0aa19fc9bb457dc4b49401710217b Mon Sep 17 00:00:00 2001 From: Gareth Kirwan Date: Tue, 21 Nov 2023 02:47:02 +0100 Subject: [PATCH] Engine: Fix panic when exchange errors (#1400) BTSE is currently failing startup. This fix simply prevents that from panicing. --- engine/helpers_test.go | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/engine/helpers_test.go b/engine/helpers_test.go index 56c3dd57..3055e944 100644 --- a/engine/helpers_test.go +++ b/engine/helpers_test.go @@ -17,6 +17,7 @@ import ( "testing" "time" + "github.com/stretchr/testify/assert" "github.com/thrasher-corp/gocryptotrader/common" "github.com/thrasher-corp/gocryptotrader/common/convert" "github.com/thrasher-corp/gocryptotrader/common/file" @@ -1372,10 +1373,8 @@ func TestNewSupportedExchangeByName(t *testing.T) { func TestNewExchangeByNameWithDefaults(t *testing.T) { t.Parallel() - _, err := NewExchangeByNameWithDefaults(context.Background(), "meow") - if !errors.Is(err, ErrExchangeNotFound) { - t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeNotFound) - } + _, err := NewExchangeByNameWithDefaults(context.Background(), "moarunlikelymeow") + assert.ErrorIs(t, err, ErrExchangeNotFound, "Invalid exchange name should error") for x := range exchange.Exchanges { name := exchange.Exchanges[x] t.Run(name, func(t *testing.T) { @@ -1387,11 +1386,8 @@ func TestNewExchangeByNameWithDefaults(t *testing.T) { t.Skipf("skipping %s unsupported", name) } exch, err := NewExchangeByNameWithDefaults(context.Background(), name) - if err != nil { - t.Error(err) - } - if !strings.EqualFold(exch.GetName(), name) { - t.Errorf("received: '%v' but expected: '%v'", exch.GetName(), name) + if assert.NoError(t, err, "NewExchangeByNameWithDefaults should not error") { + assert.Equal(t, name, strings.ToLower(exch.GetName()), "Should get correct exchange name") } }) }