mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-06-08 07:26:48 +00:00
kline/exchanges: automatic creation of unsupported candle intervals (#1091)
* kline: Add builder and testing * Ideas * kline: deploy builder functionality across GCT * exchanges: implement across gct * exchanges: Add tests and fix implementations before kline package testing and veri. * kline: Add tests and start to fix ConvertToNewInterval * kline: fix ConvertToNewInterval add tests * kline: complete overarching tests now on to exchanges * kline: finish exchange tests and implement limits * exchanges: more fixes * linter: fix * engine: fix tests * kraken: fix recent trades and other fixes * zb: fix tests * bithumb: fix empty insertion * kline: refactor/optimize CreateKline function * kline: remove the mooos! * kline: prealloc CalculateCandleDateRanges * linter: fix * exchanges: prealloc extended * fix whoopsie * reverse fix because this is a whoopsie * okx: fix risidual issues * linter: fix * kline: initial nits from @gloriouscode * kline: rename builder -> request and cascade change * linter: fix + test * kline: update forced alignment on start and end times when CreateKlineRequest is called. * nits: more more more * NITS: Addressed * tests: fix race issue * Update exchanges/kline/request.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * kline: add method AddPadding() to automatically fill in holes in kline.Request functionality and reject if missing data when converting * kline: Add params start and end to addPadding() to insert blanks in between block * kline: remove test comment code as it's not needed anymore * kline: fix lint and test * kline: sort slice without extra bool check every iteration * okx: fix issues with timeing and candles and such from niterinos & address typo * Update exchanges/kline/kline.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * glorious: niterinos * Update exchanges/poloniex/poloniex_wrapper.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * glorious: nits now onto conflicts YAYA!!! * Update exchanges/exchange_test.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * glorious: nits again * thrasher: nitters * thrasher: niterinos - adds partial flag for incomplete recent candles and fetching. * kline: rm fmtizzle packageizzle * glorious: nitters * glorious: more niterinos * fix last niterinos Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io> Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
This commit is contained in:
@@ -232,9 +232,9 @@ func SQLDataToTrade(dbTrades ...tradesql.Data) ([]Data, error) {
|
||||
}
|
||||
|
||||
// ConvertTradesToCandles turns trade data into kline.Items
|
||||
func ConvertTradesToCandles(interval kline.Interval, trades ...Data) (kline.Item, error) {
|
||||
func ConvertTradesToCandles(interval kline.Interval, trades ...Data) (*kline.Item, error) {
|
||||
if len(trades) == 0 {
|
||||
return kline.Item{}, ErrNoTradesSupplied
|
||||
return nil, ErrNoTradesSupplied
|
||||
}
|
||||
groupedData := groupTradesToInterval(interval, trades...)
|
||||
candles := kline.Item{
|
||||
@@ -247,7 +247,7 @@ func ConvertTradesToCandles(interval kline.Interval, trades ...Data) (kline.Item
|
||||
candles.Candles = append(candles.Candles, classifyOHLCV(time.Unix(k, 0), v...))
|
||||
}
|
||||
|
||||
return candles, nil
|
||||
return &candles, nil
|
||||
}
|
||||
|
||||
func groupTradesToInterval(interval kline.Interval, times ...Data) map[int64][]Data {
|
||||
|
||||
Reference in New Issue
Block a user