From 8124e55add676b34560831db64d7d29d725957d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luis=20Rasc=C3=A3o?= <luis.rascao@gmail.com>
Date: Thu, 11 Nov 2021 23:28:46 +0000
Subject: [PATCH] binance: don't enable BTC/USDT instrument without user's
 knowledge (#821)

If not instruments were enabled refrain from trying to be clever and
auto-enabling BTC/USDT.
---
 exchanges/binance/binance_wrapper.go | 59 ++--------------------------
 1 file changed, 4 insertions(+), 55 deletions(-)

diff --git a/exchanges/binance/binance_wrapper.go b/exchanges/binance/binance_wrapper.go
index 0f815316..1522faec 100644
--- a/exchanges/binance/binance_wrapper.go
+++ b/exchanges/binance/binance_wrapper.go
@@ -264,60 +264,9 @@ func (b *Binance) Run() {
 		b.PrintEnabledPairs()
 	}
 
-	forceUpdate := false
-	format, err := b.GetPairFormat(asset.Spot, false)
-	if err != nil {
-		log.Errorf(log.ExchangeSys, "%s failed to get enabled currencies. Err %s\n",
-			b.Name,
-			err)
-		return
-	}
-	pairs, err := b.GetEnabledPairs(asset.Spot)
-	if err != nil {
-		log.Errorf(log.ExchangeSys, "%s failed to get enabled currencies. Err %s\n",
-			b.Name,
-			err)
-		return
-	}
-
-	avail, err := b.GetAvailablePairs(asset.Spot)
-	if err != nil {
-		log.Errorf(log.ExchangeSys, "%s failed to get available currencies. Err %s\n",
-			b.Name,
-			err)
-		return
-	}
-
-	if !common.StringDataContains(pairs.Strings(), format.Delimiter) ||
-		!common.StringDataContains(avail.Strings(), format.Delimiter) {
-		var enabledPairs currency.Pairs
-		enabledPairs, err = currency.NewPairsFromStrings([]string{
-			currency.BTC.String() +
-				format.Delimiter +
-				currency.USDT.String()})
-		if err != nil {
-			log.Errorf(log.ExchangeSys, "%s failed to update currencies. Err %s\n",
-				b.Name,
-				err)
-		} else {
-			log.Warn(log.ExchangeSys,
-				"Available pairs for Binance reset due to config upgrade, please enable the ones you would like to use again")
-			forceUpdate = true
-
-			err = b.UpdatePairs(enabledPairs, asset.Spot, true, true)
-			if err != nil {
-				log.Errorf(log.ExchangeSys,
-					"%s failed to update currencies. Err: %s\n",
-					b.Name,
-					err)
-			}
-		}
-	}
-
 	a := b.GetAssetTypes(true)
 	for x := range a {
-		err = b.UpdateOrderExecutionLimits(context.TODO(), a[x])
-		if err != nil {
+		if err := b.UpdateOrderExecutionLimits(context.TODO(), a[x]); err != nil {
 			log.Errorf(log.ExchangeSys,
 				"%s failed to set exchange order execution limits. Err: %v",
 				b.Name,
@@ -325,11 +274,11 @@ func (b *Binance) Run() {
 		}
 	}
 
-	if !b.GetEnabledFeatures().AutoPairUpdates && !forceUpdate {
+	if !b.GetEnabledFeatures().AutoPairUpdates {
 		return
 	}
-	err = b.UpdateTradablePairs(context.TODO(), forceUpdate)
-	if err != nil {
+
+	if err := b.UpdateTradablePairs(context.TODO(), false); err != nil {
 		log.Errorf(log.ExchangeSys,
 			"%s failed to update tradable pairs. Err: %s",
 			b.Name,