Merge branch 'master' into engine

exchanges/bitflyer/bitflyer.go

@@ -323,7 +323,7 @@ func (b *Bitflyer) SendHTTPRequest(path string, result interface{}) error {
 // if you have access and update the authenticated requests
 // TODO: Fill out this function once API access is obtained
 func (b *Bitflyer) SendAuthHTTPRequest() {
-	// headers := make(map[string]string)
+	// nolint: gocritic headers := make(map[string]string)
 	// headers["ACCESS-KEY"] = b.API.Credentials.Key
 	// headers["ACCESS-TIMESTAMP"] = strconv.FormatInt(time.Now().UnixNano(), 10)
 }

exchanges/bitflyer/bitflyer_wrapper.go

@@ -1,7 +1,6 @@
 package bitflyer
 
 import (
-	"errors"
 	"strings"
 	"sync"
 	"time"
@@ -248,26 +247,13 @@ func (b *Bitflyer) UpdateOrderbook(p currency.Pair, assetType asset.Item) (order
 // GetAccountInfo retrieves balances for all enabled currencies on the
 // Bitflyer exchange
 func (b *Bitflyer) GetAccountInfo() (exchange.AccountInfo, error) {
-	var response exchange.AccountInfo
-	response.Exchange = b.GetName()
-	// accountBalance, err := b.GetAccountBalance()
-	// if err != nil {
-	// 	return response, err
-	// }
-	if !b.Enabled {
-		return response, errors.New("exchange not enabled")
-	}
-
-	// implement once authenticated requests are introduced
-
-	return response, nil
+	return exchange.AccountInfo{}, common.ErrNotYetImplemented
 }
 
 // GetFundingHistory returns funding history, deposits and
 // withdrawals
 func (b *Bitflyer) GetFundingHistory() ([]exchange.FundHistory, error) {
-	var fundHistory []exchange.FundHistory
-	return fundHistory, common.ErrFunctionNotSupported
+	return nil, common.ErrFunctionNotSupported
 }
 
 // GetExchangeHistory returns historic trade data since exchange opening.

exchanges/lbank/lbank_wrapper.go

@@ -533,13 +533,10 @@ func (l *Lbank) GetOrderHistory(getOrdersRequest *exchange.GetOrdersRequest) ([]
 	var finalResp []exchange.OrderDetail
 	var resp exchange.OrderDetail
 	var tempCurr currency.Pairs
-	var x int
 	if len(getOrdersRequest.Currencies) == 0 {
 		tempCurr = l.GetEnabledPairs(asset.Spot)
 	} else {
-		for x < len(getOrdersRequest.Currencies) {
-			tempCurr = getOrdersRequest.Currencies
-		}
+		tempCurr = getOrdersRequest.Currencies
 	}
 	for a := range tempCurr {
 		p := l.FormatExchangeCurrency(tempCurr[a], asset.Spot).String()

exchanges/websocket/wsorderbook/wsorderbook_test.go

@@ -577,6 +577,6 @@ func TestSetup(t *testing.T) {
 	w := WebsocketOrderbookLocal{}
 	w.Setup(1, true, true, true, true, "hi")
 	if w.obBufferLimit != 1 || !w.bufferEnabled || !w.sortBuffer || !w.sortBufferByUpdateIDs || !w.updateEntriesByID || w.exchangeName != "hi" {
-		t.Errorf("Setup incorrectly loaded %v", w)
+		t.Errorf("Setup incorrectly loaded %s", w.exchangeName)
 	}
 }