d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-05 23:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

build/linters: Bump Go to v1.25 and golangci-lint to v2.4.0 (#2005)

Browse Source 
* build/linters: Bump Go to v1.25 and golangci-lint to v2.4.0

* refactor: Update TODO comments for net.Listen and net.DialTimeout; improve variable naming in websocket and exchange methods

* refactor: Rename massageMissingData to backfillMissingData for clarity and update references in RSI and MFI calculations

* fix: Correct typo in TODO comment for net.Listen in RPC server
This commit is contained in:
Adrian Gallagher
2025-08-20 11:55:15 +10:00
committed by GitHub
parent 7879633c4a
commit 7ebc392532
63 changed files with 498 additions and 647 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cmd/exchange_template/exchange_template.go
View File

@@ -1,6 +1,7 @@
package main
import (
"context"
"errors"
"flag"
"fmt"
@@ -241,7 +242,7 @@ func saveConfig(exchangeDirectory string, configTestFile *config.Config, newExch
}
func runCommand(dir, param string) error {
cmd := exec.Command("go", param)
cmd := exec.CommandContext(context.TODO(), "go", param)
cmd.Dir = dir
out, err := cmd.CombinedOutput()
if err != nil {
@@ -253,11 +254,12 @@ func runCommand(dir, param string) error {
func newFile(path string) {
_, err := os.Stat(path)
if os.IsNotExist(err) {
file, err := os.Create(path)
if err != nil {
log.Fatal(err)
}
file.Close()
if !os.IsNotExist(err) {
return
}
f, err := os.Create(path)
if err != nil {
log.Fatal(err)
}
f.Close()
}

88
cmd/exchange_wrapper_issues/main.go
View File

@@ -285,10 +285,10 @@ func parseOrderType(orderType string) order.Type {
}
}
func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config) []ExchangeAssetPairResponses {
func testWrappers(e exchange.IBotExchange, base *exchange.Base, cfg *Config) []ExchangeAssetPairResponses {
response := make([]ExchangeAssetPairResponses, 0)
testOrderSide := parseOrderSide(config.OrderSubmission.OrderSide)
testOrderType := parseOrderType(config.OrderSubmission.OrderType)
testOrderSide := parseOrderSide(cfg.OrderSubmission.OrderSide)
testOrderType := parseOrderType(cfg.OrderSubmission.OrderType)
assetTypes := base.GetAssetTypes(false)
if assetTypeOverride != "" {
a, err := asset.New(assetTypeOverride)
@@ -577,8 +577,8 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
feeType := exchange.FeeBuilder{
FeeType: exchange.CryptocurrencyTradeFee,
Pair: p,
PurchasePrice: config.OrderSubmission.Price,
Amount: config.OrderSubmission.Amount,
PurchasePrice: cfg.OrderSubmission.Price,
Amount: cfg.OrderSubmission.Amount,
}
var getFeeByTypeResponse float64
getFeeByTypeResponse, err = e.GetFeeByType(context.TODO(), &feeType)
@@ -599,9 +599,9 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
Pair: p,
Side: testOrderSide,
Type: testOrderType,
Amount: config.OrderSubmission.Amount,
Price: config.OrderSubmission.Price,
ClientID: config.OrderSubmission.OrderID,
Amount: cfg.OrderSubmission.Amount,
Price: cfg.OrderSubmission.Price,
ClientID: cfg.OrderSubmission.OrderID,
AssetType: assetTypes[i],
}
var submitOrderResponse *order.SubmitResponse
@@ -619,12 +619,12 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
})
modifyRequest := order.Modify{
OrderID: config.OrderSubmission.OrderID,
OrderID: cfg.OrderSubmission.OrderID,
Type: testOrderType,
Side: testOrderSide,
Pair: p,
Price: config.OrderSubmission.Price,
Amount: config.OrderSubmission.Amount,
Price: cfg.OrderSubmission.Price,
Amount: cfg.OrderSubmission.Amount,
AssetType: assetTypes[i],
}
modifyOrderResponse, err := e.ModifyOrder(context.TODO(), &modifyRequest)
@@ -643,7 +643,7 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
cancelRequest := order.Cancel{
Side: testOrderSide,
Pair: p,
OrderID: config.OrderSubmission.OrderID,
OrderID: cfg.OrderSubmission.OrderID,
AssetType: assetTypes[i],
}
err = e.CancelOrder(context.TODO(), &cancelRequest)
@@ -663,7 +663,7 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
request = append(request, order.Cancel{
Side: testOrderSide,
Pair: p,
OrderID: config.OrderSubmission.OrderID,
OrderID: cfg.OrderSubmission.OrderID,
AssetType: assetTypes[i],
})
@@ -696,14 +696,14 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
})
var r15 *order.Detail
r15, err = e.GetOrderInfo(context.TODO(), config.OrderSubmission.OrderID, p, assetTypes[i])
r15, err = e.GetOrderInfo(context.TODO(), cfg.OrderSubmission.OrderID, p, assetTypes[i])
msg = ""
if err != nil {
msg = err.Error()
responseContainer.ErrorCount++
}
responseContainer.EndpointResponses = append(responseContainer.EndpointResponses, EndpointResponse{
SentParams: jsonifyInterface([]any{config.OrderSubmission.OrderID, p, assetTypes[i]}),
SentParams: jsonifyInterface([]any{cfg.OrderSubmission.OrderID, p, assetTypes[i]}),
Function: "GetOrderInfo",
Error: msg,
Response: jsonifyInterface([]any{r15}),
@@ -770,8 +770,8 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
feeType = exchange.FeeBuilder{
FeeType: exchange.CryptocurrencyWithdrawalFee,
Pair: p,
PurchasePrice: config.OrderSubmission.Price,
Amount: config.OrderSubmission.Amount,
PurchasePrice: cfg.OrderSubmission.Price,
Amount: cfg.OrderSubmission.Amount,
}
var GetFeeByTypeResponse float64
GetFeeByTypeResponse, err = e.GetFeeByType(context.TODO(), &feeType)
@@ -792,7 +792,7 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
Crypto: withdraw.CryptoRequest{
Address: withdrawAddressOverride,
},
Amount: config.OrderSubmission.Amount,
Amount: cfg.OrderSubmission.Amount,
}
msg = ""
err = withdrawRequest.Validate()
@@ -815,8 +815,8 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
feeType = exchange.FeeBuilder{
FeeType: exchange.InternationalBankWithdrawalFee,
Pair: p,
PurchasePrice: config.OrderSubmission.Price,
Amount: config.OrderSubmission.Amount,
PurchasePrice: cfg.OrderSubmission.Price,
Amount: cfg.OrderSubmission.Amount,
FiatCurrency: currency.AUD,
BankTransactionType: exchange.WireTransfer,
}
@@ -836,32 +836,32 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
withdrawRequestFiat := withdraw.Request{
Currency: p.Quote,
Amount: config.OrderSubmission.Amount,
Amount: cfg.OrderSubmission.Amount,
Fiat: withdraw.FiatRequest{
Bank: banking.Account{
AccountName: config.BankDetails.BankAccountName,
AccountNumber: config.BankDetails.BankAccountNumber,
SWIFTCode: config.BankDetails.SwiftCode,
IBAN: config.BankDetails.Iban,
BankPostalCity: config.BankDetails.BankCity,
BankName: config.BankDetails.BankName,
BankAddress: config.BankDetails.BankAddress,
BankCountry: config.BankDetails.BankCountry,
BankPostalCode: config.BankDetails.BankPostalCode,
BankCode: config.BankDetails.BankCode,
AccountName: cfg.BankDetails.BankAccountName,
AccountNumber: cfg.BankDetails.BankAccountNumber,
SWIFTCode: cfg.BankDetails.SwiftCode,
IBAN: cfg.BankDetails.Iban,
BankPostalCity: cfg.BankDetails.BankCity,
BankName: cfg.BankDetails.BankName,
BankAddress: cfg.BankDetails.BankAddress,
BankCountry: cfg.BankDetails.BankCountry,
BankPostalCode: cfg.BankDetails.BankPostalCode,
BankCode: cfg.BankDetails.BankCode,
},
IsExpressWire: config.BankDetails.IsExpressWire,
RequiresIntermediaryBank: config.BankDetails.RequiresIntermediaryBank,
IntermediaryBankName: config.BankDetails.IntermediaryBankName,
IntermediaryBankAccountNumber: config.BankDetails.IntermediaryBankAccountNumber,
IntermediarySwiftCode: config.BankDetails.IntermediarySwiftCode,
IntermediaryIBAN: config.BankDetails.IntermediaryIban,
IntermediaryBankCity: config.BankDetails.IntermediaryBankCity,
IntermediaryBankAddress: config.BankDetails.IntermediaryBankAddress,
IntermediaryBankCountry: config.BankDetails.IntermediaryBankCountry,
IntermediaryBankPostalCode: config.BankDetails.IntermediaryBankPostalCode,
IntermediaryBankCode: config.BankDetails.IntermediaryBankCode,
IsExpressWire: cfg.BankDetails.IsExpressWire,
RequiresIntermediaryBank: cfg.BankDetails.RequiresIntermediaryBank,
IntermediaryBankName: cfg.BankDetails.IntermediaryBankName,
IntermediaryBankAccountNumber: cfg.BankDetails.IntermediaryBankAccountNumber,
IntermediarySwiftCode: cfg.BankDetails.IntermediarySwiftCode,
IntermediaryIBAN: cfg.BankDetails.IntermediaryIban,
IntermediaryBankCity: cfg.BankDetails.IntermediaryBankCity,
IntermediaryBankAddress: cfg.BankDetails.IntermediaryBankAddress,
IntermediaryBankCountry: cfg.BankDetails.IntermediaryBankCountry,
IntermediaryBankPostalCode: cfg.BankDetails.IntermediaryBankPostalCode,
IntermediaryBankCode: cfg.BankDetails.IntermediaryBankCode,
},
}
withdrawFiatFundsResponse, err := e.WithdrawFiatFunds(context.TODO(), &withdrawRequestFiat)
@@ -1038,9 +1038,9 @@ func loadConfig() (Config, error) {
return cfg, err
}
func saveConfig(config *Config) {
func saveConfig(cfg *Config) {
log.Println("JSONifying config...")
jsonOutput, err := json.MarshalIndent(config, "", " ")
jsonOutput, err := json.MarshalIndent(cfg, "", " ")
if err != nil {
log.Fatalf("Encountered error encoding JSON: %v", err)
}

6
cmd/gctcli/commands.go
View File

@@ -2861,7 +2861,7 @@ func withdrawlRequestByExchangeID(c *cli.Context) error {
return cli.ShowSubcommandHelp(c)
}
var exchange, currency, assetType string
var exchange, ccy, assetType string
if c.IsSet("exchange") {
exchange = c.String("exchange")
} else {
@@ -2896,7 +2896,7 @@ func withdrawlRequestByExchangeID(c *cli.Context) error {
}
if c.IsSet("currency") {
currency = c.String("currency")
ccy = c.String("currency")
}
if c.IsSet("asset") {
@@ -2922,7 +2922,7 @@ func withdrawlRequestByExchangeID(c *cli.Context) error {
Exchange: exchange,
Id: ID,
Limit: int32(limit), //nolint:gosec // TODO: SQL boiler's QueryMode limit only accepts the int type
Currency: currency,
Currency: ccy,
AssetType: assetType,
},
)

4
cmd/gctcli/helpers.go
View File

@@ -22,11 +22,11 @@ var (
func clearScreen() error {
switch runtime.GOOS {
case "windows":
cmd := exec.Command("cmd", "/c", "cls")
cmd := exec.CommandContext(context.TODO(), "cmd", "/c", "cls")
cmd.Stdout = os.Stdout
return cmd.Run()
default:
cmd := exec.Command("clear")
cmd := exec.CommandContext(context.TODO(), "clear")
cmd.Stdout = os.Stdout
return cmd.Run()
}