Migrate from gometalinter.v2 to golangci-lint (#249)

* Migrate from gometalinter.v2 to golangci-lint

tools/documentation/documentation.go

@@ -278,10 +278,10 @@ func getName(name string, capital bool) string {
 }
 
 func getCapital(name string) string {
-	cap := strings.ToUpper(string(name[0]))
+	capLetter := strings.ToUpper(string(name[0]))
 	last := name[1:]
 
-	return cap + last
+	return capLetter + last
 }
 
 // getslashFromName returns a string for godoc package names
@@ -352,20 +352,20 @@ func replaceReadme(packageName string) error {
 func createReadme(packageName string) error {
 	if packageName == licenseName || packageName == contributorName {
 		file, err := os.Create(codebasePaths[packageName] + packageName)
-		defer file.Close()
 		if err != nil {
 			return err
 		}
+		defer file.Close()
 		if verbose {
 			fmt.Println("File done")
 		}
 		return tmpl.ExecuteTemplate(file, packageName, codebaseReadme[packageName])
 	}
 	file, err := os.Create(codebasePaths[packageName] + "README.md")
-	defer file.Close()
 	if err != nil {
 		return err
 	}
+	defer file.Close()
 	if verbose {
 		fmt.Println("File done")
 	}

tools/exchange_template/exchange_template.go

@@ -106,8 +106,8 @@ func main() {
 
 	var configTestExchanges []string
 
-	for _, exch := range configTestFile.Exchanges {
-		configTestExchanges = append(configTestExchanges, exch.Name)
+	for x := range configTestFile.Exchanges {
+		configTestExchanges = append(configTestExchanges, configTestFile.Exchanges[x].Name)
 	}
 
 	if common.StringDataContainsUpper(configTestExchanges, capName) {
@@ -227,9 +227,9 @@ func newFile(path string) {
 
 	if os.IsNotExist(err) {
 		var file, err = os.Create(path)
-		defer file.Close()
 		if err != nil {
 			log.Fatal("GoCryptoTrader: Exchange templating tool file creation error ", err)
 		}
+		file.Close()
 	}
 }

tools/huobi_auth/main.go

@@ -42,8 +42,8 @@ func encodePEM(privKey *ecdsa.PrivateKey, pubKey bool) ([]byte, error) {
 	), nil
 }
 
-func decodePEM(PEMPrivKey []byte) (*ecdsa.PrivateKey, error) {
-	block, _ := pem.Decode(PEMPrivKey)
+func decodePEM(pemPrivKey []byte) (*ecdsa.PrivateKey, error) {
+	block, _ := pem.Decode(pemPrivKey)
 	if block == nil {
 		return nil, errors.New("priv block data is nil")
 	}