Migrate from gometalinter.v2 to golangci-lint (#249)

* Migrate from gometalinter.v2 to golangci-lint

exchanges/alphapoint/alphapoint.go

@@ -67,11 +67,11 @@ func (a *Alphapoint) SetDefaults() {
 // GetTicker returns current ticker information from Alphapoint for a selected
 // currency pair ie "BTCUSD"
 func (a *Alphapoint) GetTicker(currencyPair string) (Ticker, error) {
-	request := make(map[string]interface{})
-	request["productPair"] = currencyPair
+	req := make(map[string]interface{})
+	req["productPair"] = currencyPair
 	response := Ticker{}
 
-	err := a.SendHTTPRequest(http.MethodPost, alphapointTicker, request, &response)
+	err := a.SendHTTPRequest(http.MethodPost, alphapointTicker, req, &response)
 	if err != nil {
 		return response, err
 	}
@@ -88,13 +88,13 @@ func (a *Alphapoint) GetTicker(currencyPair string) (Ticker, error) {
 // 0 (default: 0)
 // Count: specifies the number of trades to return (default: 10)
 func (a *Alphapoint) GetTrades(currencyPair string, startIndex, count int) (Trades, error) {
-	request := make(map[string]interface{})
-	request["ins"] = currencyPair
-	request["startIndex"] = startIndex
-	request["Count"] = count
+	req := make(map[string]interface{})
+	req["ins"] = currencyPair
+	req["startIndex"] = startIndex
+	req["Count"] = count
 	response := Trades{}
 
-	err := a.SendHTTPRequest(http.MethodPost, alphapointTrades, request, &response)
+	err := a.SendHTTPRequest(http.MethodPost, alphapointTrades, req, &response)
 	if err != nil {
 		return response, err
 	}
@@ -109,13 +109,13 @@ func (a *Alphapoint) GetTrades(currencyPair string, startIndex, count int) (Trad
 // StartDate - specifies the starting time in epoch time, type is long
 // EndDate - specifies the end time in epoch time, type is long
 func (a *Alphapoint) GetTradesByDate(currencyPair string, startDate, endDate int64) (Trades, error) {
-	request := make(map[string]interface{})
-	request["ins"] = currencyPair
-	request["startDate"] = startDate
-	request["endDate"] = endDate
+	req := make(map[string]interface{})
+	req["ins"] = currencyPair
+	req["startDate"] = startDate
+	req["endDate"] = endDate
 	response := Trades{}
 
-	err := a.SendHTTPRequest(http.MethodPost, alphapointTradesByDate, request, &response)
+	err := a.SendHTTPRequest(http.MethodPost, alphapointTradesByDate, req, &response)
 	if err != nil {
 		return response, err
 	}
@@ -128,11 +128,11 @@ func (a *Alphapoint) GetTradesByDate(currencyPair string, startDate, endDate int
 // GetOrderbook fetches the current orderbook for a given currency pair
 // CurrencyPair - trade pair (ex: “BTCUSD”)
 func (a *Alphapoint) GetOrderbook(currencyPair string) (Orderbook, error) {
-	request := make(map[string]interface{})
-	request["productPair"] = currencyPair
+	req := make(map[string]interface{})
+	req["productPair"] = currencyPair
 	response := Orderbook{}
 
-	err := a.SendHTTPRequest(http.MethodPost, alphapointOrderbook, request, &response)
+	err := a.SendHTTPRequest(http.MethodPost, alphapointOrderbook, req, &response)
 	if err != nil {
 		return response, err
 	}
@@ -183,17 +183,17 @@ func (a *Alphapoint) CreateAccount(firstName, lastName, email, phone, password s
 		)
 	}
 
-	request := make(map[string]interface{})
-	request["firstname"] = firstName
-	request["lastname"] = lastName
-	request["email"] = email
-	request["phone"] = phone
-	request["password"] = password
+	req := make(map[string]interface{})
+	req["firstname"] = firstName
+	req["lastname"] = lastName
+	req["email"] = email
+	req["phone"] = phone
+	req["password"] = password
 	response := Response{}
 
-	err := a.SendAuthenticatedHTTPRequest(http.MethodPost, alphapointCreateAccount, request, &response)
+	err := a.SendAuthenticatedHTTPRequest(http.MethodPost, alphapointCreateAccount, req, &response)
 	if err != nil {
-		return fmt.Errorf("Alphapoint Error - CreateAccount HTTPRequest - reason: %s", err)
+		return fmt.Errorf("unable to create account. Reason: %s", err)
 	}
 	if !response.IsAccepted {
 		return errors.New(response.RejectReason)
@@ -254,13 +254,13 @@ func (a *Alphapoint) SetUserInfo(firstName, lastName, cell2FACountryCode, cell2F
 		},
 	}
 
-	request := make(map[string]interface{})
-	request["userInfoKVP"] = userInfoKVPs
+	req := make(map[string]interface{})
+	req["userInfoKVP"] = userInfoKVPs
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointUserInfo,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -296,16 +296,16 @@ func (a *Alphapoint) GetAccountInformation() (AccountInfo, error) {
 // StartIndex - Starting index, if less than 0 then start from the beginning
 // Count - Returns last trade, (Default: 30)
 func (a *Alphapoint) GetAccountTrades(currencyPair string, startIndex, count int) (Trades, error) {
-	request := make(map[string]interface{})
-	request["ins"] = currencyPair
-	request["startIndex"] = startIndex
-	request["count"] = count
+	req := make(map[string]interface{})
+	req["ins"] = currencyPair
+	req["startIndex"] = startIndex
+	req["count"] = count
 	response := Trades{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointAccountTrades,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -339,17 +339,17 @@ func (a *Alphapoint) GetDepositAddresses() ([]DepositAddresses, error) {
 // amount - Amount (ex: “.011”)
 // address - Withdraw address
 func (a *Alphapoint) WithdrawCoins(symbol, product, address string, amount float64) error {
-	request := make(map[string]interface{})
-	request["ins"] = symbol
-	request["product"] = product
-	request["amount"] = strconv.FormatFloat(amount, 'f', -1, 64)
-	request["sendToAddress"] = address
+	req := make(map[string]interface{})
+	req["ins"] = symbol
+	req["product"] = product
+	req["amount"] = strconv.FormatFloat(amount, 'f', -1, 64)
+	req["sendToAddress"] = address
 
 	response := Response{}
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointWithdraw,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -377,18 +377,18 @@ func (a *Alphapoint) convertOrderTypeToOrderTypeNumber(orderType string) (orderT
 // price - Price in USD
 func (a *Alphapoint) CreateOrder(symbol, side, orderType string, quantity, price float64) (int64, error) {
 	orderTypeNumber := a.convertOrderTypeToOrderTypeNumber(orderType)
-	request := make(map[string]interface{})
-	request["ins"] = symbol
-	request["side"] = side
-	request["orderType"] = orderTypeNumber
-	request["qty"] = strconv.FormatFloat(quantity, 'f', -1, 64)
-	request["px"] = strconv.FormatFloat(price, 'f', -1, 64)
+	req := make(map[string]interface{})
+	req["ins"] = symbol
+	req["side"] = side
+	req["orderType"] = orderTypeNumber
+	req["qty"] = strconv.FormatFloat(quantity, 'f', -1, 64)
+	req["px"] = strconv.FormatFloat(price, 'f', -1, 64)
 	response := Response{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointCreateOrder,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -408,17 +408,17 @@ func (a *Alphapoint) CreateOrder(symbol, side, orderType string, quantity, price
 // book. A buy order will be modified to the highest bid and a sell order will
 // be modified to the lowest ask price. “1” means "Execute now", which will
 // convert a limit order into a market order.
-func (a *Alphapoint) ModifyExistingOrder(symbol string, OrderID, action int64) (int64, error) {
-	request := make(map[string]interface{})
-	request["ins"] = symbol
-	request["serverOrderId"] = OrderID
-	request["modifyAction"] = action
+func (a *Alphapoint) ModifyExistingOrder(symbol string, orderID, action int64) (int64, error) {
+	req := make(map[string]interface{})
+	req["ins"] = symbol
+	req["serverOrderId"] = orderID
+	req["modifyAction"] = action
 	response := Response{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointModifyOrder,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -433,16 +433,16 @@ func (a *Alphapoint) ModifyExistingOrder(symbol string, OrderID, action int64) (
 // CancelExistingOrder cancels an order that has not been executed.
 // symbol - Instrument code (ex: “BTCUSD”)
 // OrderId - Order id (ex: 1000)
-func (a *Alphapoint) CancelExistingOrder(OrderID int64, OMSID string) (int64, error) {
-	request := make(map[string]interface{})
-	request["OrderId"] = OrderID
-	request["OMSId"] = OMSID
+func (a *Alphapoint) CancelExistingOrder(orderID int64, omsid string) (int64, error) {
+	req := make(map[string]interface{})
+	req["OrderId"] = orderID
+	req["OMSId"] = omsid
 	response := Response{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointCancelOrder,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -456,15 +456,15 @@ func (a *Alphapoint) CancelExistingOrder(OrderID int64, OMSID string) (int64, er
 
 // CancelAllExistingOrders cancels all open orders by symbol
 // symbol - Instrument code (ex: “BTCUSD”)
-func (a *Alphapoint) CancelAllExistingOrders(OMSID string) error {
-	request := make(map[string]interface{})
-	request["OMSId"] = OMSID
+func (a *Alphapoint) CancelAllExistingOrders(omsid string) error {
+	req := make(map[string]interface{})
+	req["OMSId"] = omsid
 	response := Response{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointCancelAllOrders,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -501,17 +501,17 @@ func (a *Alphapoint) GetOrders() ([]OpenOrders, error) {
 // quantity - Quantity
 // price - Price in USD
 func (a *Alphapoint) GetOrderFee(symbol, side string, quantity, price float64) (float64, error) {
-	request := make(map[string]interface{})
-	request["ins"] = symbol
-	request["side"] = side
-	request["qty"] = strconv.FormatFloat(quantity, 'f', -1, 64)
-	request["px"] = strconv.FormatFloat(price, 'f', -1, 64)
+	req := make(map[string]interface{})
+	req["ins"] = symbol
+	req["side"] = side
+	req["qty"] = strconv.FormatFloat(quantity, 'f', -1, 64)
+	req["px"] = strconv.FormatFloat(price, 'f', -1, 64)
 	response := Response{}
 
 	err := a.SendAuthenticatedHTTPRequest(
 		http.MethodPost,
 		alphapointOrderFee,
-		request,
+		req,
 		&response,
 	)
 	if err != nil {
@@ -531,7 +531,7 @@ func (a *Alphapoint) SendHTTPRequest(method, path string, data map[string]interf
 
 	PayloadJSON, err := common.JSONEncode(data)
 	if err != nil {
-		return errors.New("SendHTTPRequest: Unable to JSON request")
+		return errors.New("unable to JSON request")
 	}
 
 	return a.SendPayload(method, path, headers, bytes.NewBuffer(PayloadJSON), result, false, a.Verbose)
@@ -559,7 +559,7 @@ func (a *Alphapoint) SendAuthenticatedHTTPRequest(method, path string, data map[
 
 	PayloadJSON, err := common.JSONEncode(data)
 	if err != nil {
-		return errors.New("SendAuthenticatedHTTPRequest: Unable to JSON request")
+		return errors.New("unable to JSON request")
 	}
 
 	return a.SendPayload(method, path, headers, bytes.NewBuffer(PayloadJSON), result, true, a.Verbose)

exchanges/alphapoint/alphapoint_websocket.go

@@ -42,8 +42,7 @@ func (a *Alphapoint) WebsocketClient() {
 				break
 			}
 
-			switch msgType {
-			case websocket.TextMessage:
+			if msgType == websocket.TextMessage {
 				type MsgType struct {
 					MessageType string `json:"messageType"`
 				}
@@ -55,8 +54,7 @@ func (a *Alphapoint) WebsocketClient() {
 					continue
 				}
 
-				switch msgType.MessageType {
-				case "Ticker":
+				if msgType.MessageType == "Ticker" {
 					ticker := WebsocketTicker{}
 					err = common.JSONDecode(resp, &ticker)
 					if err != nil {

exchanges/alphapoint/alphapoint_wrapper.go

@@ -8,7 +8,7 @@ import (
 
 	"github.com/thrasher-/gocryptotrader/common"
 	"github.com/thrasher-/gocryptotrader/currency/pair"
-	"github.com/thrasher-/gocryptotrader/exchanges"
+	exchange "github.com/thrasher-/gocryptotrader/exchanges"
 	"github.com/thrasher-/gocryptotrader/exchanges/orderbook"
 	"github.com/thrasher-/gocryptotrader/exchanges/ticker"
 )
@@ -133,7 +133,7 @@ func (a *Alphapoint) SubmitOrder(p pair.CurrencyPair, side exchange.OrderSide, o
 
 // ModifyOrder will allow of changing orderbook placement and limit to
 // market conversion
-func (a *Alphapoint) ModifyOrder(action exchange.ModifyOrder) (string, error) {
+func (a *Alphapoint) ModifyOrder(_ exchange.ModifyOrder) (string, error) {
 	return "", common.ErrNotYetImplemented
 }