d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-27 15:10:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/wrapper_coverage: prevent non-needed REST requests via context timeout (#1154)

Browse Source 
* wrapper_coverage/exchanges: cancel context to not send rest requests/ populate context through functions that do rest requests

* linter: fix

* exchange_template: fix test

---------

Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io>
This commit is contained in:
Ryan O'Hara-Reid
2023-04-02 11:20:25 +10:00
committed by GitHub
parent c69f48f8d7
commit 7cadc5cffb
62 changed files with 233 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
exchanges/itbit/itbit_test.go
View File

@@ -56,12 +56,12 @@ func TestMain(m *testing.M) {
func TestStart(t *testing.T) {
t.Parallel()
err := i.Start(nil)
err := i.Start(context.Background(), nil)
if !errors.Is(err, common.ErrNilPointer) {
t.Fatalf("received: '%v' but expected: '%v'", err, common.ErrNilPointer)
}
var testWg sync.WaitGroup
err = i.Start(&testWg)
err = i.Start(context.Background(), &testWg)
if err != nil {
t.Fatal(err)
}

10
exchanges/itbit/itbit_wrapper.go
View File

@@ -28,7 +28,7 @@ import (
)
// GetDefaultConfig returns a default exchange config
func (i *ItBit) GetDefaultConfig() (*config.Exchange, error) {
func (i *ItBit) GetDefaultConfig(ctx context.Context) (*config.Exchange, error) {
i.SetDefaults()
exchCfg := new(config.Exchange)
exchCfg.Name = i.Name
@@ -41,7 +41,7 @@ func (i *ItBit) GetDefaultConfig() (*config.Exchange, error) {
}
if i.Features.Supports.RESTCapabilities.AutoPairUpdates {
err = i.UpdateTradablePairs(context.TODO(), true)
err = i.UpdateTradablePairs(ctx, true)
if err != nil {
return nil, err
}
@@ -116,20 +116,20 @@ func (i *ItBit) Setup(exch *config.Exchange) error {
}
// Start starts the ItBit go routine
func (i *ItBit) Start(wg *sync.WaitGroup) error {
func (i *ItBit) Start(ctx context.Context, wg *sync.WaitGroup) error {
if wg == nil {
return fmt.Errorf("%T %w", wg, common.ErrNilPointer)
}
wg.Add(1)
go func() {
i.Run()
i.Run(ctx)
wg.Done()
}()
return nil
}
// Run implements the ItBit wrapper
func (i *ItBit) Run() {
func (i *ItBit) Run(ctx context.Context) {
if i.Verbose {
i.PrintEnabledPairs()
}