d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/wrapper_coverage: prevent non-needed REST requests via context timeout (#1154)

Browse Source 
* wrapper_coverage/exchanges: cancel context to not send rest requests/ populate context through functions that do rest requests

* linter: fix

* exchange_template: fix test

---------

Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io>
This commit is contained in:
Ryan O'Hara-Reid
2023-04-02 11:20:25 +10:00
committed by GitHub
parent c69f48f8d7
commit 7cadc5cffb
62 changed files with 233 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
exchanges/hitbtc/hitbtc_test.go
View File

@@ -59,12 +59,12 @@ func TestMain(m *testing.M) {
func TestStart(t *testing.T) {
t.Parallel()
err := h.Start(nil)
err := h.Start(context.Background(), nil)
if !errors.Is(err, common.ErrNilPointer) {
t.Fatalf("received: '%v' but expected: '%v'", err, common.ErrNilPointer)
}
var testWg sync.WaitGroup
err = h.Start(&testWg)
err = h.Start(context.Background(), &testWg)
if err != nil {
t.Fatal(err)
}

12
exchanges/hitbtc/hitbtc_wrapper.go
View File

@@ -31,7 +31,7 @@ import (
)
// GetDefaultConfig returns a default exchange config
func (h *HitBTC) GetDefaultConfig() (*config.Exchange, error) {
func (h *HitBTC) GetDefaultConfig(ctx context.Context) (*config.Exchange, error) {
h.SetDefaults()
exchCfg := new(config.Exchange)
exchCfg.Name = h.Name
@@ -44,7 +44,7 @@ func (h *HitBTC) GetDefaultConfig() (*config.Exchange, error) {
}
if h.Features.Supports.RESTCapabilities.AutoPairUpdates {
err = h.UpdateTradablePairs(context.TODO(), true)
err = h.UpdateTradablePairs(ctx, true)
if err != nil {
return nil, err
}
@@ -199,20 +199,20 @@ func (h *HitBTC) Setup(exch *config.Exchange) error {
}
// Start starts the HitBTC go routine
func (h *HitBTC) Start(wg *sync.WaitGroup) error {
func (h *HitBTC) Start(ctx context.Context, wg *sync.WaitGroup) error {
if wg == nil {
return fmt.Errorf("%T %w", wg, common.ErrNilPointer)
}
wg.Add(1)
go func() {
h.Run()
h.Run(ctx)
wg.Done()
}()
return nil
}
// Run implements the HitBTC wrapper
func (h *HitBTC) Run() {
func (h *HitBTC) Run(ctx context.Context) {
if h.Verbose {
log.Debugf(log.ExchangeSys, "%s Websocket: %s (url: %s).\n", h.Name, common.IsEnabled(h.Websocket.IsEnabled()), hitbtcWebsocketAddress)
h.PrintEnabledPairs()
@@ -273,7 +273,7 @@ func (h *HitBTC) Run() {
return
}
err := h.UpdateTradablePairs(context.TODO(), forceUpdate)
err := h.UpdateTradablePairs(ctx, forceUpdate)
if err != nil {
log.Errorf(log.ExchangeSys,
"%s failed to update tradable pairs. Err: %s",