d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-01 15:10:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/wrapper_coverage: prevent non-needed REST requests via context timeout (#1154)

Browse Source 
* wrapper_coverage/exchanges: cancel context to not send rest requests/ populate context through functions that do rest requests

* linter: fix

* exchange_template: fix test

---------

Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io>
This commit is contained in:
Ryan O'Hara-Reid
2023-04-02 11:20:25 +10:00
committed by GitHub
parent c69f48f8d7
commit 7cadc5cffb
62 changed files with 233 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
exchanges/bybit/bybit_test.go
View File

@@ -69,12 +69,12 @@ func areTestAPIKeysSet() bool {
func TestStart(t *testing.T) {
t.Parallel()
err := b.Start(nil)
err := b.Start(context.Background(), nil)
if !errors.Is(err, common.ErrNilPointer) {
t.Fatalf("received: '%v' but expected: '%v'", err, common.ErrNilPointer)
}
var testWg sync.WaitGroup
err = b.Start(&testWg)
err = b.Start(context.Background(), &testWg)
if err != nil {
t.Fatal(err)
}

12
exchanges/bybit/bybit_wrapper.go
View File

@@ -30,7 +30,7 @@ import (
)
// GetDefaultConfig returns a default exchange config
func (by *Bybit) GetDefaultConfig() (*config.Exchange, error) {
func (by *Bybit) GetDefaultConfig(ctx context.Context) (*config.Exchange, error) {
by.SetDefaults()
exchCfg := new(config.Exchange)
exchCfg.Name = by.Name
@@ -43,7 +43,7 @@ func (by *Bybit) GetDefaultConfig() (*config.Exchange, error) {
}
if by.Features.Supports.RESTCapabilities.AutoPairUpdates {
err := by.UpdateTradablePairs(context.TODO(), true)
err := by.UpdateTradablePairs(ctx, true)
if err != nil {
return nil, err
}
@@ -247,20 +247,20 @@ func (by *Bybit) AuthenticateWebsocket(ctx context.Context) error {
}
// Start starts the Bybit go routine
func (by *Bybit) Start(wg *sync.WaitGroup) error {
func (by *Bybit) Start(ctx context.Context, wg *sync.WaitGroup) error {
if wg == nil {
return fmt.Errorf("%T %w", wg, common.ErrNilPointer)
}
wg.Add(1)
go func() {
by.Run()
by.Run(ctx)
wg.Done()
}()
return nil
}
// Run implements the Bybit wrapper
func (by *Bybit) Run() {
func (by *Bybit) Run(ctx context.Context) {
if by.Verbose {
log.Debugf(log.ExchangeSys,
"%s Websocket: %s.",
@@ -273,7 +273,7 @@ func (by *Bybit) Run() {
return
}
err := by.UpdateTradablePairs(context.TODO(), false)
err := by.UpdateTradablePairs(ctx, false)
if err != nil {
log.Errorf(log.ExchangeSys,
"%s failed to update tradable pairs. Err: %s",