d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-07 23:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Binance: Fixes expiring futures contract pair formatting (#836)

Browse Source 
* Fixes expiring contract formatting

* minor simplification

* shazniterinos

* Removes secret scientific test

* continue to address nits

* Shazniterinos

* Adds `bypassConfigFormatUpgrades` feature. Fixes Binance pair parsing.

* lint fix

* Adds test for binance func

* Consistent messaging and oopsie fix
This commit is contained in:
Scott
2021-11-16 15:02:31 +11:00
committed by GitHub
parent 25e9d284d0
commit 7c7aebe22f
17 changed files with 661 additions and 373 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
exchanges/bitstamp/bitstamp_wrapper.go
View File

@@ -203,51 +203,53 @@ func (b *Bitstamp) Run() {
}
forceUpdate := false
format, err := b.GetPairFormat(asset.Spot, false)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to get pair format. Err %s\n",
b.Name,
err)
return
}
enabled, err := b.CurrencyPairs.GetPairs(asset.Spot, true)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to get enabled currencies. Err %s\n",
b.Name,
err)
return
}
avail, err := b.CurrencyPairs.GetPairs(asset.Spot, false)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to get available currencies. Err %s\n",
b.Name,
err)
return
}
if !common.StringDataContains(enabled.Strings(), format.Delimiter) ||
!common.StringDataContains(avail.Strings(), format.Delimiter) {
var enabledPairs currency.Pairs
enabledPairs, err = currency.NewPairsFromStrings([]string{
currency.BTC.String() + format.Delimiter + currency.USD.String(),
})
if !b.BypassConfigFormatUpgrades {
format, err := b.GetPairFormat(asset.Spot, false)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to update currencies. Err %s\n",
log.Errorf(log.ExchangeSys, "%s failed to get pair format. Err %s\n",
b.Name,
err)
} else {
log.Warn(log.ExchangeSys,
"Bitstamp: Enabled and available pairs reset due to config upgrade, please enable the ones you would like to use again")
forceUpdate = true
return
}
err = b.UpdatePairs(enabledPairs, asset.Spot, true, true)
enabled, err := b.CurrencyPairs.GetPairs(asset.Spot, true)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to get enabled currencies. Err %s\n",
b.Name,
err)
return
}
avail, err := b.CurrencyPairs.GetPairs(asset.Spot, false)
if err != nil {
log.Errorf(log.ExchangeSys, "%s failed to get available currencies. Err %s\n",
b.Name,
err)
return
}
if !common.StringDataContains(enabled.Strings(), format.Delimiter) ||
!common.StringDataContains(avail.Strings(), format.Delimiter) {
var enabledPairs currency.Pairs
enabledPairs, err = currency.NewPairsFromStrings([]string{
currency.BTC.String() + format.Delimiter + currency.USD.String(),
})
if err != nil {
log.Errorf(log.ExchangeSys,
"%s failed to update currencies. Err: %s\n",
log.Errorf(log.ExchangeSys, "%s failed to update currencies. Err %s\n",
b.Name,
err)
} else {
log.Warnf(log.ExchangeSys,
exchange.ResetConfigPairsWarningMessage, b.Name, asset.Spot, enabledPairs)
forceUpdate = true
err = b.UpdatePairs(enabledPairs, asset.Spot, true, true)
if err != nil {
log.Errorf(log.ExchangeSys,
"%s failed to update currencies. Err: %s\n",
b.Name,
err)
}
}
}
}
@@ -256,7 +258,7 @@ func (b *Bitstamp) Run() {
return
}
err = b.UpdateTradablePairs(context.TODO(), forceUpdate)
err := b.UpdateTradablePairs(context.TODO(), forceUpdate)
if err != nil {
log.Errorf(log.ExchangeSys,
"%s failed to update tradable pairs. Err: %s",