okcoin: Remove exchange implementation (#1626)

* okcoin: Remove exchange implementation

* exchanges/order: Rid TradeMode from Submit type

cmd/apichecker/apicheck.go

@@ -32,7 +32,6 @@ const (
 	github               = "GitHub Sha Check"
 	htmlScrape           = "HTML String Check"
 	pathBinance          = "https://binance-docs.github.io/apidocs/spot/en/#change-log"
-	pathOkCoin           = "https://www.okcoin.com/docs/en/#change-change"
 	pathBTSE             = "https://www.btse.com/apiexplorer/spot/#btse-spot-api"
 	pathBitfinex         = "https://docs.bitfinex.com/docs/changelog"
 	pathBitmex           = "https://www.bitmex.com/static/md/en-US/apiChangelog"
@@ -63,7 +62,6 @@ const (
 	createCard           = "UpdatesCard"
 	createChecklist      = "UpdatesChecklist"
 	btcMarkets           = "BTC Markets"
-	okcoin               = "Okcoin"
 )
 
 var (
@@ -483,8 +481,6 @@ func checkChangeLog(htmlData *HTMLScrapingData) (string, error) {
 		dataStrings, err = htmlScrapeAlphaPoint(htmlData)
 	case pathYobit:
 		dataStrings, err = htmlScrapeYobit(htmlData)
-	case pathOkCoin:
-		dataStrings, err = htmlScrapeOk(htmlData)
 	default:
 		dataStrings, err = htmlScrapeDefault(htmlData)
 	}
@@ -1143,7 +1139,7 @@ func nameStateChanges(currentName, currentState string) (string, error) {
 	var num int64
 	var err error
 	switch currentName {
-	case btcMarkets, okcoin:
+	case btcMarkets:
 		if strings.Count(currentName, " ") == 2 {
 			exists = true
 		}

cmd/apichecker/apicheck_test.go

@@ -246,23 +246,6 @@ func TestHTMLScrapeHitBTC(t *testing.T) {
 	}
 }
 
-func TestHTMLScrapeDefault(t *testing.T) {
-	t.Parallel()
-	data := HTMLScrapingData{TokenData: "h3",
-		Key:           "id",
-		Val:           "change-change",
-		TokenDataEnd:  "section",
-		TextTokenData: "p",
-		DateFormat:    "2006-01-02",
-		RegExp:        "(2\\d{3}-\\d{1,2}-\\d{1,2})",
-		CheckString:   "2019-04-28",
-		Path:          "https://www.okcoin.com/docs/en/#change-change"}
-	_, err := htmlScrapeDefault(&data)
-	if err != nil {
-		t.Error(err)
-	}
-}
-
 func TestHTMLScrapeBTSE(t *testing.T) {
 	t.Parallel()
 	data := HTMLScrapingData{RegExp: `^version: \d{1}.\d{1}.\d{1}`,

cmd/apichecker/testupdates.json

@@ -302,22 +302,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Okcoin",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "Val": "./#change-change",
-     "TokenDataEnd": "./#change-",
-     "RegExp": "./#change-\\d{8}",
-     "CheckString": "20200229",
-     "Path": "https://www.okcoin.com/docs/en/#change-change"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Gemini",
    "CheckType": "HTML String Check",

cmd/apichecker/updates.json

@@ -302,22 +302,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "Okcoin",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "Val": "./#change-change",
-     "TokenDataEnd": "./#change-",
-     "RegExp": "./#change-\\d{8}",
-     "CheckString": "20200229",
-     "Path": "https://www.okcoin.com/docs/en/#change-change"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Gemini",
    "CheckType": "HTML String Check",

cmd/documentation/exchanges_templates/exchanges_trade_readme.tmpl

@@ -63,7 +63,6 @@ _b in this context is an `IBotExchange` implemented struct_
 | Kraken | Yes | Yes | No |
 | Kucoin | Yes | No | Yes |
 | Lbank | Yes | No | Yes |
-| Okcoin | Yes | Yes | Yes |
 | Okx | Yes | Yes | Yes |
 | Poloniex | Yes | Yes | Yes |
 | Yobit | Yes | NA | No |

cmd/documentation/exchanges_templates/okcoin.tmpl

@@ -1,106 +0,0 @@
-{{define "exchanges okcoin" -}}
-{{template "header" .}}
-## Okcoin Exchange
-
-### Current Features
-
-+ REST Support
-+ Websocket Support
-
-### How to enable
-
-+ [Enable via configuration](https://github.com/thrasher-corp/gocryptotrader/tree/master/config#enable-exchange-via-config-example)
-
-+ Individual package example below:
-
-```go
-	// Exchanges will be abstracted out in further updates and examples will be
-	// supplied then
-```
-
-### How to do REST public/private calls
-
-+ If enabled via "configuration".json file the exchange will be added to the
-IBotExchange array in the ```go var bot Bot``` and you will only be able to use
-the wrapper interface functions for accessing exchange data. View routines.go
-for an example of integration usage with GoCryptoTrader. Rudimentary example
-below:
-
-main.go
-```go
-var o exchange.IBotExchange
-
-for i := range bot.Exchanges {
-	if bot.Exchanges[i].GetName() == "Okcoin" {
-		o = bot.Exchanges[i]
-	}
-}
-
-// Public calls - wrapper functions
-
-// Fetches current ticker information
-tick, err := o.FetchTicker()
-if err != nil {
-	// Handle error
-}
-
-// Fetches current orderbook information
-ob, err := o.FetchOrderbook()
-if err != nil {
-	// Handle error
-}
-
-// Private calls - wrapper functions - make sure your APIKEY and APISECRET are
-// set and AuthenticatedAPISupport is set to true
-
-// Fetches current account information
-accountInfo, err := o.GetAccountInfo()
-if err != nil {
-	// Handle error
-}
-```
-
-+ If enabled via individually importing package, rudimentary example below:
-
-```go
-// Public calls
-
-// Fetches current ticker information
-ticker, err := o.GetTicker()
-if err != nil {
-	// Handle error
-}
-
-// Fetches current orderbook information
-ob, err := o.GetOrderBook()
-if err != nil {
-	// Handle error
-}
-
-// Private calls - make sure your APIKEY and APISECRET are set and
-// AuthenticatedAPISupport is set to true
-
-// GetUserInfo returns account info
-accountInfo, err := o.GetUserInfo(...)
-if err != nil {
-	// Handle error
-}
-
-// Submits an order and the exchange and returns its tradeID
-tradeID, err := o.Trade(...)
-if err != nil {
-	// Handle error
-}
-```
-
-### How to do Websocket public/private calls
-
-```go
-	// Exchanges will be abstracted out in further updates and examples will be
-	// supplied then
-```
-
-### Please click GoDocs chevron above to view current GoDoc information for this package
-{{template "contributions"}}
-{{template "donations" .}}
-{{end}}

cmd/documentation/root_templates/root_readme.tmpl

@@ -41,7 +41,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | NA |
 | Lbank | Yes | No | NA |
-| Okcoin | Yes | Yes | No |
 | Okx | Yes | Yes | NA |
 | Poloniex | Yes | Yes | NA |
 | Yobit | Yes | NA | NA |