d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-20 23:16:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

accounts: Move to instance methods, fix races and isolate tests (#1923)

Browse Source 
* Bybit: Fix race in TestUpdateAccountInfo and  TestWSHandleData

* DriveBy rename TestWSHandleData
* This doesn't address running with -race=2+ due to the singleton

* Accounts: Add account.GetService()

* exchange: Assertify TestSetupDefaults

* Exchanges: Add account.Service override for testing

* Exchanges: Remove duplicate IsWebsocketEnabled test from TestSetupDefaults

* Dispatch: Replace nil checks with NilGuard

* Engine: Remove deprecated printAccountHoldingsChangeSummary

* Dispatcher: Add EnsureRunning method

* Accounts: Move singleton accounts service to exchange Accounts

* Move singleton accounts service to exchange Accounts

This maintains the concept of a global store, whilst allowing exchanges
to override it when needed, particularly for testing.

APIServer:

* Remove getAllActiveAccounts from apiserver

Deprecated apiserver only thing using this, so remove it instead of
updating it

* Update comment for UpdateAccountBalances everywhere

* Docs: Add punctuation to function comments

* Bybit: Coverage for wsProcessWalletPushData Save
This commit is contained in:
Gareth Kirwan
2025-10-28 09:52:45 +07:00
committed by GitHub
parent bda9bbec66
commit 73e200e4e7
140 changed files with 3515 additions and 4025 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
dispatch/dispatch_test.go
View File

@@ -9,6 +9,7 @@ import (
"github.com/gofrs/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/thrasher-corp/gocryptotrader/common"
)
var (
@@ -22,8 +23,17 @@ func TestGlobalDispatcher(t *testing.T) {
assert.True(t, IsRunning(), "IsRunning should return true")
err = Stop()
assert.NoError(t, err, "Stop should not error")
require.NoError(t, err, "Stop must not error")
assert.False(t, IsRunning(), "IsRunning should return false")
err = EnsureRunning(0, 0)
require.NoError(t, err, "EnsureRunning must not error when starting")
assert.True(t, IsRunning(), "IsRunning should return true after EnsureRunning")
err = EnsureRunning(0, 0)
require.NoError(t, err, "EnsureRunning must not error when called twice")
assert.NoError(t, Stop(), "Stop should not error")
}
func TestStartStop(t *testing.T) {
@@ -33,10 +43,10 @@ func TestStartStop(t *testing.T) {
assert.False(t, d.isRunning(), "IsRunning should return false")
err := d.stop()
assert.ErrorIs(t, err, errDispatcherNotInitialized, "stop should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "stop should error correctly")
err = d.start(10, 0)
assert.ErrorIs(t, err, errDispatcherNotInitialized, "start should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "start should error correctly")
d = NewDispatcher()
@@ -49,7 +59,7 @@ func TestStartStop(t *testing.T) {
assert.True(t, d.isRunning(), "IsRunning should return true")
err = d.start(0, 0)
assert.ErrorIs(t, err, errDispatcherAlreadyRunning, "start should error correctly")
assert.ErrorIs(t, err, ErrDispatcherAlreadyRunning, "start should error correctly")
// Add route option
id, err := d.getNewID(uuid.NewV4)
@@ -74,7 +84,7 @@ func TestSubscribe(t *testing.T) {
t.Parallel()
var d *Dispatcher
_, err := d.subscribe(uuid.Nil)
assert.ErrorIs(t, err, errDispatcherNotInitialized, "subscribe should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "subscribe should error correctly")
d = NewDispatcher()
@@ -97,7 +107,7 @@ func TestSubscribe(t *testing.T) {
_, err = d.subscribe(id)
assert.ErrorIs(t, err, errTypeAssertionFailure, "subscribe should error correctly")
d.outbound.New = getChan
d.outbound.New = func() any { return make(chan any) }
ch, err := d.subscribe(id)
assert.NoError(t, err, "subscribe should not error")
assert.NotNil(t, ch, "Channel should not be nil")
@@ -108,7 +118,7 @@ func TestUnsubscribe(t *testing.T) {
var d *Dispatcher
err := d.unsubscribe(uuid.Nil, nil)
assert.ErrorIs(t, err, errDispatcherNotInitialized, "unsubscribe should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "unsubscribe should error correctly")
d = NewDispatcher()
@@ -152,7 +162,7 @@ func TestPublish(t *testing.T) {
var d *Dispatcher
err := d.publish(uuid.Nil, nil)
assert.ErrorIs(t, err, errDispatcherNotInitialized, "publish should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "publish should error correctly")
d = NewDispatcher()
@@ -162,11 +172,11 @@ func TestPublish(t *testing.T) {
err = d.start(2, 10)
require.NoError(t, err, "start must not error")
err = d.publish(uuid.Nil, nil)
err = d.publish(uuid.Nil, "test")
assert.ErrorIs(t, err, errIDNotSet, "publish should error correctly")
err = d.publish(nonEmptyUUID, nil)
assert.ErrorIs(t, err, errNoData, "publish should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "publish should error correctly")
// demonstrate job limit error
d.routes[nonEmptyUUID] = []chan any{
@@ -209,7 +219,7 @@ func TestGetNewID(t *testing.T) {
var d *Dispatcher
_, err := d.getNewID(uuid.NewV4)
assert.ErrorIs(t, err, errDispatcherNotInitialized, "getNewID should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "getNewID should error correctly")
d = NewDispatcher()
@@ -233,16 +243,16 @@ func TestMux(t *testing.T) {
t.Parallel()
var mux *Mux
_, err := mux.Subscribe(uuid.Nil)
assert.ErrorIs(t, err, errMuxIsNil, "Subscribe should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "Subscribe should error correctly")
err = mux.Unsubscribe(uuid.Nil, nil)
assert.ErrorIs(t, err, errMuxIsNil, "Unsubscribe should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "Unsubscribe should error correctly")
err = mux.Publish(nil)
assert.ErrorIs(t, err, errMuxIsNil, "Publish should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "Publish should error correctly")
_, err = mux.GetID()
assert.ErrorIs(t, err, errMuxIsNil, "GetID should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "GetID should error correctly")
d := NewDispatcher()
err = d.start(0, 0)
@@ -251,7 +261,7 @@ func TestMux(t *testing.T) {
mux = GetNewMux(d)
err = mux.Publish(nil)
assert.ErrorIs(t, err, errNoData, "Publish should error correctly")
assert.ErrorIs(t, err, common.ErrNilPointer, "Publish should error correctly")
err = mux.Publish("lol")
assert.ErrorIs(t, err, errNoIDs, "Publish should error correctly")