mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-06-03 23:16:53 +00:00
accounts: Move to instance methods, fix races and isolate tests (#1923)
* Bybit: Fix race in TestUpdateAccountInfo and TestWSHandleData * DriveBy rename TestWSHandleData * This doesn't address running with -race=2+ due to the singleton * Accounts: Add account.GetService() * exchange: Assertify TestSetupDefaults * Exchanges: Add account.Service override for testing * Exchanges: Remove duplicate IsWebsocketEnabled test from TestSetupDefaults * Dispatch: Replace nil checks with NilGuard * Engine: Remove deprecated printAccountHoldingsChangeSummary * Dispatcher: Add EnsureRunning method * Accounts: Move singleton accounts service to exchange Accounts * Move singleton accounts service to exchange Accounts This maintains the concept of a global store, whilst allowing exchanges to override it when needed, particularly for testing. APIServer: * Remove getAllActiveAccounts from apiserver Deprecated apiserver only thing using this, so remove it instead of updating it * Update comment for UpdateAccountBalances everywhere * Docs: Add punctuation to function comments * Bybit: Coverage for wsProcessWalletPushData Save
This commit is contained in:
@@ -22,9 +22,8 @@ const (
|
||||
APIEndpointChange = "change"
|
||||
)
|
||||
|
||||
// CurrencyLayer is a foreign exchange rate provider at
|
||||
// https://currencylayer.com NOTE default base currency is USD when using a free
|
||||
// account. Has automatic upgrade to a SSL connection.
|
||||
// CurrencyLayer is a foreign exchange rate provider at https://currencylayer.com
|
||||
// NOTE default base currency is USD when using a free account
|
||||
type CurrencyLayer struct {
|
||||
base.Base
|
||||
Requester *request.Requester
|
||||
|
||||
Reference in New Issue
Block a user