Engine QA (#381)

* 1) Update Dockerfile/docker-compose.yml
2) Remove inline strings for buy/sell/test pairs
3) Remove dangerous order submission values
4) Fix consistency with audit_events (all other spec files use
CamelCase)
5) Update web websocket endpoint
6) Fix main param set (and induce dryrun mode on specific command line
params)

* Engine QA

Link up exchange syncer to cmd params, disarm market selling bombs and fix OKEX endpoints

* Fix linter issue after merge

* Engine QA changes

Template updates
Wrapper code cleanup
Disarmed order bombs
Documentation updates

* Daily engine QA

Bitstamp improvements
Spelling mistakes
Add Coinbene exchange to support list
Protect API authenticated calls for Coinbene/LBank

* Engine QA changes

Fix exchange_wrapper_coverage tool
Add SupportsAsset to exchange interface
Fix inline string usage and add BCH withdrawal support

* Engine QA

Fix Bitstamp types
Inform user of errors when parsing time accross the codebase
Change time parsing warnings to errors (as they are)
Update markdown docs [with linter fixes]

* Engine QA changes

1) Add test for dryrunParamInteraction
2) Disarm OKCoin/OKEX bombs if someone accidently sets canManipulateRealOrders to true and runs all package tests
3) Actually check exchange setup errors for BTSE and Coinbene, plus address this in the wrapper template
4) Hardcode missing/non-retrievable contributors and bump the contributors
5) Convert numbers/strings to meaningful types in Bitstamp and OKEX
6) If WS is supported for the exchange wrapper template, preset authWebsocketSupport var

* Fix the shadow people

* Link the SyncContinuously paramerino

* Also show SyncContinuously in engine.PrintSettings

* Address nitterinos and use correct filepath for logs

* Bitstamp: Extract ALL THE APM

* Fix additional nitterinos

* Fix time parsing error for Bittrex

exchanges/binance/binance.go

@@ -87,8 +87,7 @@ func (b *Binance) GetExchangeInfo() (ExchangeInfo, error) {
 // symbol: string of currency pair
 // limit: returned limit amount
 func (b *Binance) GetOrderBook(obd OrderBookDataRequestParams) (OrderBook, error) {
-	orderbook, resp := OrderBook{}, OrderBookData{}
-
+	var orderbook OrderBook
 	if err := b.CheckLimit(obd.Limit); err != nil {
 		return orderbook, err
 	}
@@ -97,42 +96,44 @@ func (b *Binance) GetOrderBook(obd OrderBookDataRequestParams) (OrderBook, error
 	params.Set("symbol", strings.ToUpper(obd.Symbol))
 	params.Set("limit", fmt.Sprintf("%d", obd.Limit))
 
-	path := fmt.Sprintf("%s%s?%s", b.API.Endpoints.URL, orderBookDepth, params.Encode())
-
+	var resp OrderBookData
+	path := common.EncodeURLValues(b.API.Endpoints.URL+orderBookDepth, params)
 	if err := b.SendHTTPRequest(path, &resp); err != nil {
 		return orderbook, err
 	}
 
-	for _, asks := range resp.Asks {
-		var ASK struct {
-			Price    float64
-			Quantity float64
+	for x := range resp.Bids {
+		price, err := strconv.ParseFloat(resp.Bids[x][0], 64)
+		if err != nil {
+			return orderbook, err
 		}
-		for i, ask := range asks.([]interface{}) {
-			switch i {
-			case 0:
-				ASK.Price, _ = strconv.ParseFloat(ask.(string), 64)
-			case 1:
-				ASK.Quantity, _ = strconv.ParseFloat(ask.(string), 64)
-				orderbook.Asks = append(orderbook.Asks, ASK)
-			}
+
+		amount, err := strconv.ParseFloat(resp.Bids[x][1], 64)
+		if err != nil {
+			return orderbook, err
 		}
+
+		orderbook.Bids = append(orderbook.Bids, OrderbookItem{
+			Price:    price,
+			Quantity: amount,
+		})
 	}
 
-	for _, bids := range resp.Bids {
-		var BID struct {
-			Price    float64
-			Quantity float64
+	for x := range resp.Asks {
+		price, err := strconv.ParseFloat(resp.Asks[x][0], 64)
+		if err != nil {
+			return orderbook, err
 		}
-		for i, bid := range bids.([]interface{}) {
-			switch i {
-			case 0:
-				BID.Price, _ = strconv.ParseFloat(bid.(string), 64)
-			case 1:
-				BID.Quantity, _ = strconv.ParseFloat(bid.(string), 64)
-				orderbook.Bids = append(orderbook.Bids, BID)
-			}
+
+		amount, err := strconv.ParseFloat(resp.Asks[x][1], 64)
+		if err != nil {
+			return orderbook, err
 		}
+
+		orderbook.Asks = append(orderbook.Asks, OrderbookItem{
+			Price:    price,
+			Quantity: amount,
+		})
 	}
 
 	orderbook.LastUpdateID = resp.LastUpdateID

exchanges/binance/binance_test.go

@@ -359,7 +359,7 @@ func TestSubmitOrder(t *testing.T) {
 			Quote:     currency.BTC,
 		},
 		OrderSide: order.Buy,
-		OrderType: order.Market,
+		OrderType: order.Limit,
 		Price:     1,
 		Amount:    1000000000,
 		ClientID:  "meowOrder",

exchanges/binance/binance_types.go

@@ -59,13 +59,19 @@ type OrderBookDataRequestParams struct {
 	Limit  int    `json:"limit"`  // Default 100; max 1000. Valid limits:[5, 10, 20, 50, 100, 500, 1000]
 }
 
+// OrderbookItem stores an individual orderbook item
+type OrderbookItem struct {
+	Price    float64
+	Quantity float64
+}
+
 // OrderBookData is resp data from orderbook endpoint
 type OrderBookData struct {
-	Code         int           `json:"code"`
-	Msg          string        `json:"msg"`
-	LastUpdateID int64         `json:"lastUpdateId"`
-	Bids         []interface{} `json:"bids"`
-	Asks         []interface{} `json:"asks"`
+	Code         int        `json:"code"`
+	Msg          string     `json:"msg"`
+	LastUpdateID int64      `json:"lastUpdateId"`
+	Bids         [][]string `json:"bids"`
+	Asks         [][]string `json:"asks"`
 }
 
 // OrderBook actual structured data that can be used for orderbook
@@ -73,14 +79,8 @@ type OrderBook struct {
 	LastUpdateID int64
 	Code         int
 	Msg          string
-	Bids         []struct {
-		Price    float64
-		Quantity float64
-	}
-	Asks []struct {
-		Price    float64
-		Quantity float64
-	}
+	Bids         []OrderbookItem
+	Asks         []OrderbookItem
 }
 
 // DepthUpdateParams is used as an embedded type for WebsocketDepthStream

exchanges/binance/binance_wrapper.go

@@ -383,8 +383,7 @@ func (b *Binance) GetAccountInfo() (exchange.AccountInfo, error) {
 // GetFundingHistory returns funding history, deposits and
 // withdrawals
 func (b *Binance) GetFundingHistory() ([]exchange.FundHistory, error) {
-	var fundHistory []exchange.FundHistory
-	return fundHistory, common.ErrFunctionNotSupported
+	return nil, common.ErrFunctionNotSupported
 }
 
 // GetExchangeHistory returns historic trade data since exchange opening.