d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 23:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Poloniex: Implementation of GetOrderInfo method (#607)

Browse Source 
* GetClosedOrder implemented for Kraken and Binance, fixed Binance MARKET order creaton, added rate, fee and cost fileds on SubmitOrder responce

* return Trades on Binance SubmitOrder, new validation methods on Binance and kraken GetClosedOrderInfo

* removed the Binance extra method GetClosedOrder

* func description corrected

* removed price, fee and cost from SimulateOrder response, as we get all necessary info in response to calculate them on client side

* GetClosedOrder implementation moved to GetOrderInfo

* changed GetOrderInfo params

* removed Canceled order.Type used for Kraken

* update QueryOrder in gctscript

* add missed params to QueryOrder validator (gctscript)

* fixed testing issues

* GetClosedOrder implemented for Kraken and Binance, fixed Binance MARKET order creaton, added rate, fee and cost fileds on SubmitOrder responce

* return Trades on Binance SubmitOrder, new validation methods on Binance and kraken GetClosedOrderInfo

* removed the Binance extra method GetClosedOrder

* func description corrected

* removed price, fee and cost from SimulateOrder response, as we get all necessary info in response to calculate them on client side

* GetClosedOrder implementation moved to GetOrderInfo

* changed GetOrderInfo params

* removed Canceled order.Type used for Kraken

* update QueryOrder in gctscript

* add missed params to QueryOrder validator (gctscript)

* fixed testing issues

* pull previous changes

* linter issues fix

* updated query_order exmple in gctscript, fixed params check

* removed orderPair unnecessary conversion

* added wsCancelAllOrders, fixed bugs

* fixed Kraken wsAddOrder method

* cleanup

* CancelBatchOrders implementation

* changed CancelBatchOrders signature

* fixed tests and wrappers

* btcmarkets_test fix

* cleanup

* cleanup

* changed CancelBatchOrders signature

* fmt

* Update configtest.json

* Update configtest.json

* rollback configtest

* refactored Kraken wsHandleData to allow tests

* removed unnecessary error test in TestWsAddOrderJSON

* dependencies updates

* fixed issue with PortfolioSleepDelay set on startup

* add GetWithdrawalsHistory method to exchanges interface

* param name changes

* add extra params for Binance WithdrawStatus method

* add Binance TestWithdrawHistory

* add GetOrderInfo on Poloniex

* linter errors fix

* switch interface type to avoid panic

* Poloniex has no para errror in OrderbookResponse - removed, added seq param (incrementing sequence) for future use

* linter issues fix

* linter issues fix

* dependencies update

* add tests

* refactored unmarshalling of GetAuthenticatedOrderStatus response

* test fix

* linter issues fix

* unmarshaling logic moved to GetAuthenticatedOrderStatus

* forced Status setting on GetAuthenticatedOrderStatus error

* comment edited

Co-authored-by: Vazha Bezhanishvili <vazha.bezhanishvili@elegro.eu>
This commit is contained in:
Vazha
2020-12-15 00:54:17 +02:00
committed by GitHub
parent ddd19ab6d9
commit 622e5dc8c8
11 changed files with 1801 additions and 1388 deletions
Download Patch File Download Diff File Expand all files Collapse all files

107
testdata/http_mock/poloniex/poloniex.json vendored
View File

@@ -10060,6 +10060,113 @@
"09c436ba3cbb06aa182ea43f85e368258d3da18fc948ca980d431cf2779f7626226129ce3482ebbeb7a0804c1b0a1155a977d6f79fff5fadedb2199f900d6a07"
]
}
},
{
"data": [
{
"globalTradeID": 394127362,
"tradeID": 13536351,
"currencyPair": "BTC_STR",
"type": "buy",
"rate": "0.00003432",
"amount": "3696.05342780",
"total": "0.12684855",
"fee": "0.00200000",
"date": "2018-10-16 17:03:43"
},
{
"globalTradeID": 394127361,
"tradeID": 13536350,
"currencyPair": "BTC_STR",
"type": "buy",
"rate": "0.00003432",
"amount": "3600.53748129",
"total": "0.12357044",
"fee": "0.00200000",
"date": "2018-10-16 17:03:43"
}
],
"queryString": "",
"bodyParams": "command=returnOrderTrades\u0026nonce=1594157624217368019\u0026orderNumber=96238912841",
"headers": {
"Content-Type": [
"application/x-www-form-urlencoded"
],
"Key": [
""
],
"Sign": [
"db30a451e3277242dd56ba0d0f73e1ca58b6b6891afbc8a5ae13c388a95ffd6ae6f6e63d0b6915e481f35bfcc84b3c73395666f28e76912c7178a440d46de43c"
]
}
},
{
"data": {
"error": "Order not found, or you are not the person who placed it."
},
"queryString": "",
"bodyParams": "command=returnOrderTrades\u0026nonce=1594157624217368020\u0026orderNumber=96238912842",
"headers": {
"Content-Type": [
"application/x-www-form-urlencoded"
],
"Key": [
""
],
"Sign": [
"db30a451e3277242dd56ba0d0f73e1ca58b6b6891afbc8a5ae13c388a95ffd6ae6f6e63d0b6915e481f35bfcc84b3c73395666f28e76912c7178a440d46de43c"
]
}
},
{
"data": {
"result":{
"6071071":{
"status":"Open",
"rate":"0.40000000",
"amount":"1.00000000",
"currencyPair":"BTC_ETH",
"date":"2018-10-17 17:04:50",
"total":"0.40000000",
"type":"buy",
"startingAmount":"1.00000"
}
},
"success":1
},
"queryString": "",
"bodyParams": "command=returnOrderStatus\u0026nonce=1594157624217368022\u0026orderNumber=96238912841",
"headers": {
"Content-Type": [
"application/x-www-form-urlencoded"
],
"Key": [
""
],
"Sign": [
"db30a451e3277242dd56ba0d0f73e1ca58b6b6891afbc8a5ae13c388a95ffd6ae6f6e63d0b6915e481f35bfcc84b3c73395666f28e76912c7178a440d46de43c"
]
}
},
{
"data": {
"result":{
"error": "Order not found, or you are not the person who placed it."
}
},
"queryString": "",
"bodyParams": "command=returnOrderStatus\u0026nonce=1594157624217368022\u0026orderNumber=96238912842",
"headers": {
"Content-Type": [
"application/x-www-form-urlencoded"
],
"Key": [
""
],
"Sign": [
"db30a451e3277242dd56ba0d0f73e1ca58b6b6891afbc8a5ae13c388a95ffd6ae6f6e63d0b6915e481f35bfcc84b3c73395666f28e76912c7178a440d46de43c"
]
}
}
]
}