linters: Exclude govet shadow check on exchange instances (#2097)

* Linters: Exclude govet shadow check on e in tests * Linters: Remove nolint rule for new(Exchange) in tests Replay with: ``` perl -pi -e 's{(\se\s:=\s.*?)\s*//nolint:govet // Intentional shadow.*}{$1}' **/*_test.go ```
2026-06-07 23:16:53 +00:00 · 2025-10-29 05:30:23 +07:00
parent a7ff3efdcc
commit 5d6755b76e
23 changed files with 106 additions and 102 deletions
--- a/exchanges/bybit/bybit_test.go
+++ b/exchanges/bybit/bybit_test.go
@@ -2784,7 +2784,7 @@ func TestUpdateAccountBalances(t *testing.T) {
 		sharedtestvalues.SkipTestIfCredentialsUnset(t, e)
 	}

-	e := testInstance() //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
+	e := testInstance()

 	subAccts, err := e.UpdateAccountBalances(t.Context(), asset.Spot)
 	require.NoError(t, err, "UpdateAccountBalances must not error")
@@ -2988,7 +2988,7 @@ var pushDataMap = map[string]string{
 func TestWSHandleData(t *testing.T) {
 	t.Parallel()

-	e := testInstance() //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
+	e := testInstance()

 	keys := slices.Collect(maps.Keys(pushDataMap))
 	slices.Sort(keys)
@@ -3011,7 +3011,7 @@ func TestWSHandleAuthenticatedData(t *testing.T) {
 	err = e.wsHandleAuthenticatedData(t.Context(), nil, []byte(`{"topic": "unhandled"}`))
 	require.ErrorIs(t, err, errUnhandledStreamData, "wsHandleAuthenticatedData must error for unhandled stream data")

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
 	e.API.AuthenticatedSupport = true
 	e.API.AuthenticatedWebsocketSupport = true
@@ -3159,7 +3159,7 @@ func TestWSHandleAuthenticatedData(t *testing.T) {

 func TestWsTicker(t *testing.T) {
 	t.Parallel()
-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
 	assetRouting := []asset.Item{
 		asset.Spot, asset.Options, asset.USDTMarginedFutures, asset.USDTMarginedFutures,
@@ -3647,7 +3647,7 @@ func TestGetCurrencyTradeURL(t *testing.T) {
 func TestGenerateSubscriptions(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	e.Websocket.SetCanUseAuthenticatedEndpoints(true)
@@ -3691,7 +3691,7 @@ func TestGenerateSubscriptions(t *testing.T) {
 func TestAuthSubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
 	require.NoError(t, e.authSubscribe(t.Context(), &FixtureConnection{}, subscription.List{}))

@@ -3711,7 +3711,7 @@ func TestAuthSubscribe(t *testing.T) {
 func TestWebsocketAuthenticatePrivateConnection(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e))

 	err := e.WebsocketAuthenticatePrivateConnection(t.Context(), &FixtureConnection{})
@@ -3730,7 +3730,7 @@ func TestWebsocketAuthenticatePrivateConnection(t *testing.T) {
 func TestWebsocketAuthenticateTradeConnection(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e))

 	err := e.WebsocketAuthenticateTradeConnection(t.Context(), &FixtureConnection{})
--- a/exchanges/bybit/bybit_websocket_requests_test.go
+++ b/exchanges/bybit/bybit_websocket_requests_test.go
@@ -53,7 +53,7 @@ func TestWSCreateOrder(t *testing.T) {
 	require.ErrorIs(t, err, errInvalidTriggerPriceType)

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)
 	got, err := e.WSCreateOrder(t.Context(), &PlaceOrderRequest{
 		Category:      cSpot,
 		Symbol:        currency.NewBTCUSDT(),
@@ -84,7 +84,7 @@ func TestWebsocketSubmitOrder(t *testing.T) {
 	require.ErrorIs(t, err, order.ErrAmountMustBeSet)

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)

 	s.Type = order.Limit
 	s.Price = 55000
@@ -109,7 +109,7 @@ func TestWSAmendOrder(t *testing.T) {
 	require.ErrorIs(t, err, errEitherOrderIDOROrderLinkIDRequired)

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t)        //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)
 	arg.OrderID = "1793353687809485568" // Replace with a valid order ID
 	arg.OrderQuantity = 0.0002
 	got, err := e.WSAmendOrder(t.Context(), arg)
@@ -127,7 +127,7 @@ func TestWebsocketModifyOrder(t *testing.T) {
 	}

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)

 	got, err := e.WebsocketModifyOrder(t.Context(), mod)
 	require.NoError(t, err)
@@ -162,7 +162,7 @@ func TestWSCancelOrder(t *testing.T) {
 	arg.OrderFilter = "Order"

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)
 	got, err := e.WSCancelOrder(t.Context(), arg)
 	require.NoError(t, err)
 	require.NotEmpty(t, got)
@@ -177,7 +177,7 @@ func TestWebsocketCancelOrder(t *testing.T) {
 	}

 	sharedtestvalues.SkipTestIfCredentialsUnset(t, e, canManipulateRealOrders)
-	e := getWebsocketInstance(t) //nolint:govet // Intentional shadow
+	e := getWebsocketInstance(t)

 	err := e.WebsocketCancelOrder(t.Context(), cancel)
 	require.NoError(t, err)
@@ -194,7 +194,7 @@ func getWebsocketInstance(t *testing.T) *Exchange {
 	require.NoError(t, err)

 	pairs := &e.CurrencyPairs
-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	e.SetDefaults()
 	bConf, err := cfg.GetExchangeConfig("Bybit")
 	require.NoError(t, err)
--- a/exchanges/bybit/inverse_websocket_test.go
+++ b/exchanges/bybit/inverse_websocket_test.go
@@ -11,7 +11,7 @@ import (

 func TestGenerateInverseDefaultSubscriptions(t *testing.T) {
 	t.Parallel()
-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
 	subs, err := e.GenerateInverseDefaultSubscriptions()
 	require.NoError(t, err, "GenerateInverseDefaultSubscriptions must not error")
@@ -31,7 +31,7 @@ func TestGenerateInverseDefaultSubscriptions(t *testing.T) {
 func TestInverseSubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateInverseDefaultSubscriptions()
@@ -44,7 +44,7 @@ func TestInverseSubscribe(t *testing.T) {
 func TestInverseUnsubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateInverseDefaultSubscriptions()
--- a/exchanges/bybit/linear_websocket_test.go
+++ b/exchanges/bybit/linear_websocket_test.go
@@ -15,7 +15,7 @@ func TestGenerateLinearDefaultSubscriptions(t *testing.T) {
 	_, err := e.GenerateLinearDefaultSubscriptions(asset.OptionCombo)
 	assert.ErrorIs(t, err, asset.ErrInvalidAsset)

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateLinearDefaultSubscriptions(asset.USDTMarginedFutures)
@@ -43,7 +43,7 @@ func TestGenerateLinearDefaultSubscriptions(t *testing.T) {
 func TestLinearSubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateLinearDefaultSubscriptions(asset.USDTMarginedFutures)
@@ -60,7 +60,7 @@ func TestLinearSubscribe(t *testing.T) {
 func TestLinearUnsubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateLinearDefaultSubscriptions(asset.USDTMarginedFutures)
--- a/exchanges/bybit/options_websocket_test.go
+++ b/exchanges/bybit/options_websocket_test.go
@@ -11,7 +11,7 @@ import (

 func TestGenerateOptionsDefaultSubscriptions(t *testing.T) {
 	t.Parallel()
-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
 	subs, err := e.GenerateOptionsDefaultSubscriptions()
 	require.NoError(t, err, "GenerateOptionsDefaultSubscriptions must not error")
@@ -31,7 +31,7 @@ func TestGenerateOptionsDefaultSubscriptions(t *testing.T) {
 func TestOptionSubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateOptionsDefaultSubscriptions()
@@ -44,7 +44,7 @@ func TestOptionSubscribe(t *testing.T) {
 func TestOptionsUnsubscribe(t *testing.T) {
 	t.Parallel()

-	e := new(Exchange) //nolint:govet // Intentional shadow
+	e := new(Exchange)
 	require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")

 	subs, err := e.GenerateOptionsDefaultSubscriptions()