d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 23:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

linters: Exclude govet shadow check on exchange instances (#2097)

Browse Source 
* Linters: Exclude govet shadow check on e in tests

* Linters: Remove nolint rule for new(Exchange) in tests

Replay with:
```
perl -pi -e 's{(\se\s:=\s.*?)\s*//nolint:govet // Intentional shadow.*}{$1}' **/*_test.go
```
This commit is contained in:
Gareth Kirwan
2025-10-29 05:30:23 +07:00
committed by GitHub
parent a7ff3efdcc
commit 5d6755b76e
23 changed files with 106 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
exchanges/binance/binance_test.go
View File

@@ -1710,7 +1710,7 @@ func TestCancelAllExchangeOrders(t *testing.T) {
func TestUpdateAccountBalances(t *testing.T) {
t.Parallel()
sharedtestvalues.SkipTestIfCredentialsUnset(t, e)
e := new(Exchange) //nolint:govet // Intentional shadow to avoid future copy/paste mistakes
e := new(Exchange)
require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
items := asset.Items{
asset.CoinMarginedFutures,
@@ -1987,7 +1987,7 @@ func BenchmarkWsHandleData(bb *testing.B) {
func TestSubscribe(t *testing.T) {
t.Parallel()
e := new(Exchange) //nolint:govet // Intentional shadow
e := new(Exchange)
require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
channels, err := e.generateSubscriptions() // Note: We grab this before it's overwritten by MockWsInstance below
require.NoError(t, err, "generateSubscriptions must not error")
@@ -2093,7 +2093,7 @@ func TestWsTradeUpdate(t *testing.T) {
func TestWsDepthUpdate(t *testing.T) {
t.Parallel()
e := new(Exchange) //nolint:govet // Intentional shadow
e := new(Exchange)
require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
e.setupOrderbookManager(t.Context())
seedLastUpdateID := int64(161)
@@ -2459,7 +2459,7 @@ var websocketDepthUpdate = []byte(`{"E":1608001030784,"U":7145637266,"a":[["1945
func TestProcessOrderbookUpdate(t *testing.T) {
t.Parallel()
e := new(Exchange) //nolint:govet // Intentional shadow
e := new(Exchange)
require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
e.setupOrderbookManager(t.Context())
p := currency.NewBTCUSDT()
@@ -2507,7 +2507,7 @@ func TestUFuturesHistoricalTrades(t *testing.T) {
func TestWsOrderExecutionReport(t *testing.T) {
t.Parallel()
e := new(Exchange) //nolint:govet // Intentional shadow
e := new(Exchange)
require.NoError(t, testexch.Setup(e), "Test instance Setup must not error")
payload := []byte(`{"stream":"jTfvpakT2yT0hVIo5gYWVihZhdM2PrBgJUZ5PyfZ4EVpCkx4Uoxk5timcrQc","data":{"e":"executionReport","E":1616627567900,"s":"BTCUSDT","c":"c4wyKsIhoAaittTYlIVLqk","S":"BUY","o":"LIMIT","f":"GTC","q":"0.00028400","p":"52789.10000000","P":"0.00000000","F":"0.00000000","g":-1,"C":"","x":"NEW","X":"NEW","r":"NONE","i":5340845958,"l":"0.00000000","z":"0.00000000","L":"0.00000000","n":"0","N":"BTC","T":1616627567900,"t":-1,"I":11388173160,"w":true,"m":false,"M":false,"O":1616627567900,"Z":"0.00000000","Y":"0.00000000","Q":"0.00000000","W":1616627567900}}`)
// this is a buy BTC order, normally commission is charged in BTC, vice versa.