modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID

gctscript/vm/autoload.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"slices"
 
 	"github.com/thrasher-corp/gocryptotrader/common"
 	"github.com/thrasher-corp/gocryptotrader/log"
@@ -19,7 +20,7 @@ func (g *GctScriptManager) Autoload(name string, remove bool) error {
 			if g.config.AutoLoad[x] != name {
 				continue
 			}
-			g.config.AutoLoad = append(g.config.AutoLoad[:x], g.config.AutoLoad[x+1:]...)
+			g.config.AutoLoad = slices.Delete(g.config.AutoLoad, x, x+1)
 			if g.config.Verbose {
 				log.Debugf(log.GCTScriptMgr, "Removing script: %s from autoload", name)
 			}

gctscript/vm/gctscript.go

@@ -52,7 +52,7 @@ func (g *GctScriptManager) ShutdownAll() (err error) {
 	}
 
 	var shutdownErrors []error
-	AllVMSync.Range(func(_, v interface{}) bool {
+	AllVMSync.Range(func(_, v any) bool {
 		vm, ok := v.(*VM)
 		if !ok {
 			shutdownErrors = append(shutdownErrors, common.GetTypeAssertError("*VM", v))

gctscript/vm/vm_types.go

@@ -34,7 +34,7 @@ const (
 type vmscount uint64
 
 var (
-	pool = &sync.Pool{New: func() interface{} { return new(tengo.Script) }}
+	pool = &sync.Pool{New: func() any { return new(tengo.Script) }}
 	// AllVMSync stores all current Virtual Machine instances
 	AllVMSync = &sync.Map{}
 	// VMSCount running total count of Virtual Machines