d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 15:09:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

Browse Source 
* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID
This commit is contained in:
Adrian Gallagher
2025-03-21 09:17:10 +11:00
committed by GitHub
parent d857d704e3
commit 4651af5767
223 changed files with 1504 additions and 1752 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gctscript/modules/gct/errors.go
View File

@@ -17,7 +17,7 @@ var (
// errorResponsef is a helper function to apply error details to a return object
// for better script side error handling
func errorResponsef(format string, a ...interface{}) (objects.Object, error) {
func errorResponsef(format string, a ...any) (objects.Object, error) {
if format == "" {
return nil, fmt.Errorf("cannot generate tengo error object %w", errFormatStringIsEmpty)
}
@@ -31,7 +31,7 @@ func errorResponsef(format string, a ...interface{}) (objects.Object, error) {
}, nil
}
func constructRuntimeError(argPosition int, funcName, expectedType string, unexpectedData interface{}) error {
func constructRuntimeError(argPosition int, funcName, expectedType string, unexpectedData any) error {
return fmt.Errorf("function [%s] argument position [%d] - %w",
funcName,
argPosition,

4
gctscript/modules/ta/indicators/atr.go
View File

@@ -40,7 +40,7 @@ func atr(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -48,7 +48,7 @@ func atr(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

6
gctscript/modules/ta/indicators/bbands.go
View File

@@ -53,7 +53,7 @@ func bbands(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[1])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -61,8 +61,8 @@ func bbands(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
var t []interface{}
t, ok = ohlcvInputData[x].([]interface{})
var t []any
t, ok = ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

4
gctscript/modules/ta/indicators/correlation.go
View File

@@ -43,14 +43,14 @@ func correlationCoefficient(args ...objects.Object) (objects.Object, error) {
var allErrors []string
ohlcvProcessor := func(args []objects.Object, idx int) ([]float64, error) {
ohlcvInput := objects.ToInterface(args[idx])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
var ohlcvClose []float64
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

4
gctscript/modules/ta/indicators/ema.go
View File

@@ -41,7 +41,7 @@ func ema(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -49,7 +49,7 @@ func ema(args ...objects.Object) (objects.Object, error) {
ohlcvClose := make([]float64, len(ohlcvInputData))
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

2
gctscript/modules/ta/indicators/indicators.go
View File

@@ -14,7 +14,7 @@ const OHLCV = "OHLCV data"
var errInvalidSelector = errors.New("invalid selector")
func toFloat64(data interface{}) (float64, error) {
func toFloat64(data any) (float64, error) {
switch d := data.(type) {
case float64:
return d, nil

4
gctscript/modules/ta/indicators/macd.go
View File

@@ -42,7 +42,7 @@ func macd(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -50,7 +50,7 @@ func macd(args ...objects.Object) (objects.Object, error) {
ohlcvClose := make([]float64, len(ohlcvInputData))
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

4
gctscript/modules/ta/indicators/mfi.go
View File

@@ -41,7 +41,7 @@ func mfi(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -49,7 +49,7 @@ func mfi(args ...objects.Object) (objects.Object, error) {
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

4
gctscript/modules/ta/indicators/obv.go
View File

@@ -40,7 +40,7 @@ func obv(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -48,7 +48,7 @@ func obv(args ...objects.Object) (objects.Object, error) {
ohlcvData := make([][]float64, 6)
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

4
gctscript/modules/ta/indicators/rsi.go
View File

@@ -41,7 +41,7 @@ func rsi(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -49,7 +49,7 @@ func rsi(args ...objects.Object) (objects.Object, error) {
ohlcvClose := make([]float64, len(ohlcvInputData))
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, errors.New("ohlcvInputData type assert failed")
}

6
gctscript/modules/ta/indicators/sma.go
View File

@@ -42,7 +42,7 @@ func sma(args ...objects.Object) (objects.Object, error) {
}
ohlcvInput := objects.ToInterface(args[0])
ohlcvInputData, valid := ohlcvInput.([]interface{})
ohlcvInputData, valid := ohlcvInput.([]any)
if !valid {
return nil, fmt.Errorf(modules.ErrParameterConvertFailed, OHLCV)
}
@@ -50,9 +50,9 @@ func sma(args ...objects.Object) (objects.Object, error) {
ohlcvClose := make([]float64, len(ohlcvInputData))
var allErrors []string
for x := range ohlcvInputData {
t, ok := ohlcvInputData[x].([]interface{})
t, ok := ohlcvInputData[x].([]any)
if !ok {
return nil, common.GetTypeAssertError("[]interface{}", ohlcvInputData[x])
return nil, common.GetTypeAssertError("[]any", ohlcvInputData[x])
}
if len(t) < 5 {
return nil, errors.New("ohlcvInputData invalid data length")

3
gctscript/vm/autoload.go
View File

@@ -4,6 +4,7 @@ import (
"fmt"
"os"
"path/filepath"
"slices"
"github.com/thrasher-corp/gocryptotrader/common"
"github.com/thrasher-corp/gocryptotrader/log"
@@ -19,7 +20,7 @@ func (g *GctScriptManager) Autoload(name string, remove bool) error {
if g.config.AutoLoad[x] != name {
continue
}
g.config.AutoLoad = append(g.config.AutoLoad[:x], g.config.AutoLoad[x+1:]...)
g.config.AutoLoad = slices.Delete(g.config.AutoLoad, x, x+1)
if g.config.Verbose {
log.Debugf(log.GCTScriptMgr, "Removing script: %s from autoload", name)
}

2
gctscript/vm/gctscript.go
View File

@@ -52,7 +52,7 @@ func (g *GctScriptManager) ShutdownAll() (err error) {
}
var shutdownErrors []error
AllVMSync.Range(func(_, v interface{}) bool {
AllVMSync.Range(func(_, v any) bool {
vm, ok := v.(*VM)
if !ok {
shutdownErrors = append(shutdownErrors, common.GetTypeAssertError("*VM", v))

2
gctscript/vm/vm_types.go
View File

@@ -34,7 +34,7 @@ const (
type vmscount uint64
var (
pool = &sync.Pool{New: func() interface{} { return new(tengo.Script) }}
pool = &sync.Pool{New: func() any { return new(tengo.Script) }}
// AllVMSync stores all current Virtual Machine instances
AllVMSync = &sync.Map{}
// VMSCount running total count of Virtual Machines