modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID

exchanges/trade/trade.go

@@ -3,6 +3,7 @@ package trade
 import (
 	"errors"
 	"fmt"
+	"slices"
 	"sort"
 	"sync"
 	"sync/atomic"
@@ -29,7 +30,7 @@ func (p *Processor) setup(wg *sync.WaitGroup) {
 
 // Setup configures necessary fields to the `Trade` structure that govern trade data
 // processing.
-func (t *Trade) Setup(tradeFeedEnabled bool, c chan interface{}) {
+func (t *Trade) Setup(tradeFeedEnabled bool, c chan any) {
 	t.dataHandler = c
 	t.tradeFeedEnabled = tradeFeedEnabled
 }
@@ -125,8 +126,7 @@ func (p *Processor) Run(wg *sync.WaitGroup) {
 	for {
 		<-ticker.C
 		p.mutex.Lock()
-		//nolint: gocritic
-		bufferCopy := append(p.buffer[:0:0], p.buffer...)
+		bufferCopy := slices.Clone(p.buffer)
 		p.buffer = nil
 		p.mutex.Unlock()
 		if len(bufferCopy) == 0 {

exchanges/trade/trade_types.go

@@ -27,7 +27,7 @@ var (
 // Trade used to hold data and methods related to trade dissemination and
 // storage
 type Trade struct {
-	dataHandler      chan interface{}
+	dataHandler      chan any
 	tradeFeedEnabled bool
 }