d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 15:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

Browse Source 
* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID
This commit is contained in:
Adrian Gallagher
2025-03-21 09:17:10 +11:00
committed by GitHub
parent d857d704e3
commit 4651af5767
223 changed files with 1504 additions and 1752 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
exchanges/coinbasepro/coinbasepro.go
View File

@@ -68,7 +68,7 @@ func (c *CoinbasePro) GetProducts(ctx context.Context) ([]Product, error) {
}
// GetOrderbook returns orderbook by currency pair and level
func (c *CoinbasePro) GetOrderbook(ctx context.Context, symbol string, level int) (interface{}, error) {
func (c *CoinbasePro) GetOrderbook(ctx context.Context, symbol string, level int) (any, error) {
orderbook := OrderbookResponse{}
path := fmt.Sprintf("%s/%s/%s", coinbaseproProducts, symbol, coinbaseproOrderbook)
@@ -337,7 +337,7 @@ func (c *CoinbasePro) GetHolds(ctx context.Context, accountID string) ([]Account
// postOnly - [optional] Post only flag Invalid when time_in_force is IOC or FOK
func (c *CoinbasePro) PlaceLimitOrder(ctx context.Context, clientRef string, price, amount float64, side string, timeInforce RequestParamsTimeForceType, cancelAfter, productID, stp string, postOnly bool) (string, error) {
resp := GeneralizedOrderResponse{}
req := make(map[string]interface{})
req := make(map[string]any)
req["type"] = order.Limit.Lower()
req["price"] = strconv.FormatFloat(price, 'f', -1, 64)
req["size"] = strconv.FormatFloat(amount, 'f', -1, 64)
@@ -386,7 +386,7 @@ func (c *CoinbasePro) PlaceLimitOrder(ctx context.Context, clientRef string, pri
// * One of size or funds is required.
func (c *CoinbasePro) PlaceMarketOrder(ctx context.Context, clientRef string, size, funds float64, side, productID, stp string) (string, error) {
resp := GeneralizedOrderResponse{}
req := make(map[string]interface{})
req := make(map[string]any)
req["side"] = side
req["product_id"] = productID
req["type"] = order.Market.Lower()
@@ -429,7 +429,7 @@ func (c *CoinbasePro) PlaceMarketOrder(ctx context.Context, clientRef string, si
// funds - [optional]* Desired amount of quote currency to use
func (c *CoinbasePro) PlaceMarginOrder(ctx context.Context, clientRef string, size, funds float64, side, productID, stp string) (string, error) {
resp := GeneralizedOrderResponse{}
req := make(map[string]interface{})
req := make(map[string]any)
req["side"] = side
req["product_id"] = productID
req["type"] = "margin"
@@ -468,7 +468,7 @@ func (c *CoinbasePro) CancelExistingOrder(ctx context.Context, orderID string) e
// canceled
func (c *CoinbasePro) CancelAllExistingOrders(ctx context.Context, currencyPair string) ([]string, error) {
var resp []string
req := make(map[string]interface{})
req := make(map[string]any)
if currencyPair != "" {
req["product_id"] = currencyPair
@@ -538,7 +538,7 @@ func (c *CoinbasePro) GetFills(ctx context.Context, orderID, currencyPair string
// currency - currency to transfer, currently on "BTC" or "USD"
func (c *CoinbasePro) MarginTransfer(ctx context.Context, amount float64, transferType, profileID, currency string) (MarginTransfer, error) {
resp := MarginTransfer{}
req := make(map[string]interface{})
req := make(map[string]any)
req["type"] = transferType
req["amount"] = strconv.FormatFloat(amount, 'f', -1, 64)
req["currency"] = currency
@@ -560,7 +560,7 @@ func (c *CoinbasePro) GetPosition(ctx context.Context) (AccountOverview, error)
// repayOnly - allows the position to be repaid
func (c *CoinbasePro) ClosePosition(ctx context.Context, repayOnly bool) (AccountOverview, error) {
resp := AccountOverview{}
req := make(map[string]interface{})
req := make(map[string]any)
req["repay_only"] = repayOnly
return resp,
@@ -583,7 +583,7 @@ func (c *CoinbasePro) GetPayMethods(ctx context.Context) ([]PaymentMethod, error
// paymentID - ID of the payment method
func (c *CoinbasePro) DepositViaPaymentMethod(ctx context.Context, amount float64, currency, paymentID string) (DepositWithdrawalInfo, error) {
resp := DepositWithdrawalInfo{}
req := make(map[string]interface{})
req := make(map[string]any)
req["amount"] = amount
req["currency"] = currency
req["payment_method_id"] = paymentID
@@ -602,7 +602,7 @@ func (c *CoinbasePro) DepositViaPaymentMethod(ctx context.Context, amount float6
// accountID - ID of the coinbase account
func (c *CoinbasePro) DepositViaCoinbase(ctx context.Context, amount float64, currency, accountID string) (DepositWithdrawalInfo, error) {
resp := DepositWithdrawalInfo{}
req := make(map[string]interface{})
req := make(map[string]any)
req["amount"] = amount
req["currency"] = currency
req["coinbase_account_id"] = accountID
@@ -618,7 +618,7 @@ func (c *CoinbasePro) DepositViaCoinbase(ctx context.Context, amount float64, cu
// paymentID - ID of the payment method
func (c *CoinbasePro) WithdrawViaPaymentMethod(ctx context.Context, amount float64, currency, paymentID string) (DepositWithdrawalInfo, error) {
resp := DepositWithdrawalInfo{}
req := make(map[string]interface{})
req := make(map[string]any)
req["amount"] = amount
req["currency"] = currency
req["payment_method_id"] = paymentID
@@ -635,7 +635,7 @@ func (c *CoinbasePro) WithdrawViaPaymentMethod(ctx context.Context, amount float
// accountID - ID of the coinbase account
// func (c *CoinbasePro) WithdrawViaCoinbase(amount float64, currency, accountID string) (DepositWithdrawalInfo, error) {
// resp := DepositWithdrawalInfo{}
// req := make(map[string]interface{})
// req := make(map[string]any)
// req["amount"] = amount
// req["currency"] = currency
// req["coinbase_account_id"] = accountID
@@ -651,7 +651,7 @@ func (c *CoinbasePro) WithdrawViaPaymentMethod(ctx context.Context, amount float
// cryptoAddress - A crypto address of the recipient
func (c *CoinbasePro) WithdrawCrypto(ctx context.Context, amount float64, currency, cryptoAddress string) (DepositWithdrawalInfo, error) {
resp := DepositWithdrawalInfo{}
req := make(map[string]interface{})
req := make(map[string]any)
req["amount"] = amount
req["currency"] = currency
req["crypto_address"] = cryptoAddress
@@ -682,7 +682,7 @@ func (c *CoinbasePro) GetCoinbaseAccounts(ctx context.Context) ([]CoinbaseAccoun
// email - [optional] Email address to send the report to
func (c *CoinbasePro) GetReport(ctx context.Context, reportType, startDate, endDate, currencyPair, accountID, format, email string) (Report, error) {
resp := Report{}
req := make(map[string]interface{})
req := make(map[string]any)
req["type"] = reportType
req["start_date"] = startDate
req["end_date"] = endDate
@@ -731,7 +731,7 @@ func (c *CoinbasePro) GetTransfers(ctx context.Context, profileID, transferType
return nil, err
}
}
req := make(map[string]interface{})
req := make(map[string]any)
if profileID != "" {
req["profile_id"] = profileID
}
@@ -752,7 +752,7 @@ func (c *CoinbasePro) GetTransfers(ctx context.Context, profileID, transferType
}
// SendHTTPRequest sends an unauthenticated HTTP request
func (c *CoinbasePro) SendHTTPRequest(ctx context.Context, ep exchange.URL, path string, result interface{}) error {
func (c *CoinbasePro) SendHTTPRequest(ctx context.Context, ep exchange.URL, path string, result any) error {
endpoint, err := c.API.Endpoints.GetURL(ep)
if err != nil {
return err
@@ -773,7 +773,7 @@ func (c *CoinbasePro) SendHTTPRequest(ctx context.Context, ep exchange.URL, path
}
// SendAuthenticatedHTTPRequest sends an authenticated HTTP request
func (c *CoinbasePro) SendAuthenticatedHTTPRequest(ctx context.Context, ep exchange.URL, method, path string, params map[string]interface{}, result interface{}) (err error) {
func (c *CoinbasePro) SendAuthenticatedHTTPRequest(ctx context.Context, ep exchange.URL, method, path string, params map[string]any, result any) (err error) {
creds, err := c.GetCredentials(ctx)
if err != nil {
return err

64
exchanges/coinbasepro/coinbasepro_types.go
View File

@@ -95,12 +95,12 @@ type AccountResponse struct {
// AccountLedgerResponse holds account history information
type AccountLedgerResponse struct {
ID string `json:"id"`
CreatedAt time.Time `json:"created_at"`
Amount float64 `json:"amount,string"`
Balance float64 `json:"balance,string"`
Type string `json:"type"`
Details interface{} `json:"details"`
ID string `json:"id"`
CreatedAt time.Time `json:"created_at"`
Amount float64 `json:"amount,string"`
Balance float64 `json:"balance,string"`
Type string `json:"type"`
Details any `json:"details"`
}
// AccountHolds contains the hold information about an account
@@ -341,9 +341,9 @@ type OrderbookL3 struct {
// OrderbookResponse is a generalized response for order books
type OrderbookResponse struct {
Sequence int64 `json:"sequence"`
Bids [][3]interface{} `json:"bids"`
Asks [][3]interface{} `json:"asks"`
Sequence int64 `json:"sequence"`
Bids [][3]any `json:"bids"`
Asks [][3]any `json:"asks"`
}
// FillResponse contains fill information from the exchange
@@ -460,31 +460,31 @@ type wsMsgType struct {
type wsStatus struct {
Currencies []struct {
ConvertibleTo []string `json:"convertible_to"`
Details struct{} `json:"details"`
ID string `json:"id"`
MaxPrecision float64 `json:"max_precision,string"`
MinSize float64 `json:"min_size,string"`
Name string `json:"name"`
Status string `json:"status"`
StatusMessage interface{} `json:"status_message"`
ConvertibleTo []string `json:"convertible_to"`
Details struct{} `json:"details"`
ID string `json:"id"`
MaxPrecision float64 `json:"max_precision,string"`
MinSize float64 `json:"min_size,string"`
Name string `json:"name"`
Status string `json:"status"`
StatusMessage any `json:"status_message"`
} `json:"currencies"`
Products []struct {
BaseCurrency string `json:"base_currency"`
BaseIncrement float64 `json:"base_increment,string"`
BaseMaxSize float64 `json:"base_max_size,string"`
BaseMinSize float64 `json:"base_min_size,string"`
CancelOnly bool `json:"cancel_only"`
DisplayName string `json:"display_name"`
ID string `json:"id"`
LimitOnly bool `json:"limit_only"`
MaxMarketFunds float64 `json:"max_market_funds,string"`
MinMarketFunds float64 `json:"min_market_funds,string"`
PostOnly bool `json:"post_only"`
QuoteCurrency string `json:"quote_currency"`
QuoteIncrement float64 `json:"quote_increment,string"`
Status string `json:"status"`
StatusMessage interface{} `json:"status_message"`
BaseCurrency string `json:"base_currency"`
BaseIncrement float64 `json:"base_increment,string"`
BaseMaxSize float64 `json:"base_max_size,string"`
BaseMinSize float64 `json:"base_min_size,string"`
CancelOnly bool `json:"cancel_only"`
DisplayName string `json:"display_name"`
ID string `json:"id"`
LimitOnly bool `json:"limit_only"`
MaxMarketFunds float64 `json:"max_market_funds,string"`
MinMarketFunds float64 `json:"min_market_funds,string"`
PostOnly bool `json:"post_only"`
QuoteCurrency string `json:"quote_currency"`
QuoteIncrement float64 `json:"quote_increment,string"`
Status string `json:"status"`
StatusMessage any `json:"status_message"`
} `json:"products"`
Type string `json:"type"`
}