modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID

exchanges/bithumb/bithumb.go

@@ -530,7 +530,7 @@ func (b *Bithumb) MarketSellOrder(ctx context.Context, pair currency.Pair, units
 }
 
 // SendHTTPRequest sends an unauthenticated HTTP request
-func (b *Bithumb) SendHTTPRequest(ctx context.Context, ep exchange.URL, path string, result interface{}) error {
+func (b *Bithumb) SendHTTPRequest(ctx context.Context, ep exchange.URL, path string, result any) error {
 	endpoint, err := b.API.Endpoints.GetURL(ep)
 	if err != nil {
 		return err
@@ -549,7 +549,7 @@ func (b *Bithumb) SendHTTPRequest(ctx context.Context, ep exchange.URL, path str
 }
 
 // SendAuthenticatedHTTPRequest sends an authenticated HTTP request to bithumb
-func (b *Bithumb) SendAuthenticatedHTTPRequest(ctx context.Context, ep exchange.URL, path string, params url.Values, result interface{}) error {
+func (b *Bithumb) SendAuthenticatedHTTPRequest(ctx context.Context, ep exchange.URL, path string, params url.Values, result any) error {
 	creds, err := b.GetCredentials(ctx)
 	if err != nil {
 		return err

exchanges/bithumb/bithumb_types.go

@@ -83,9 +83,9 @@ type Account struct {
 
 // Balance holds balance details
 type Balance struct {
-	Status  string                 `json:"status"`
-	Data    map[string]interface{} `json:"data"`
-	Message string                 `json:"message"`
+	Status  string         `json:"status"`
+	Data    map[string]any `json:"data"`
+	Message string         `json:"message"`
 }
 
 // WalletAddressRes contains wallet address information
@@ -290,8 +290,8 @@ type FullBalance struct {
 
 // OHLCVResponse holds returned kline data
 type OHLCVResponse struct {
-	Status string           `json:"status"`
-	Data   [][6]interface{} `json:"data"`
+	Status string   `json:"status"`
+	Data   [][6]any `json:"data"`
 }
 
 // Status defines the current exchange allowance to deposit or withdraw a

exchanges/bithumb/bithumb_websocket_test.go

@@ -54,7 +54,7 @@ func TestWsHandleData(t *testing.T) {
 				},
 			},
 			Websocket: &stream.Websocket{
-				DataHandler: make(chan interface{}, 1),
+				DataHandler: make(chan any, 1),
 			},
 		},
 	}