modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID

engine/sync_manager.go

@@ -30,6 +30,7 @@ const (
 	SyncItemOrderbook
 	SyncItemTrade
 	SyncManagerName = "exchange_syncer"
+	minSyncInterval = time.Second
 )
 
 var (
@@ -452,10 +453,7 @@ func (m *SyncManager) worker() {
 	}
 	defer cleanup()
 
-	interval := greatestCommonDivisor(m.config.TimeoutWebsocket, m.config.TimeoutREST)
-	if interval > time.Second {
-		interval = time.Second
-	}
+	interval := min(greatestCommonDivisor(m.config.TimeoutWebsocket, m.config.TimeoutREST), minSyncInterval)
 	t := time.NewTicker(interval)
 
 	for {
@@ -905,7 +903,7 @@ func (m *SyncManager) WaitForInitialSync() error {
 	return nil
 }
 
-func relayWebsocketEvent(result interface{}, event, assetType, exchangeName string) {
+func relayWebsocketEvent(result any, event, assetType, exchangeName string) {
 	evt := WebsocketEvent{
 		Data:      result,
 		Event:     event,