modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID
This commit is contained in:
Adrian Gallagher
2025-03-21 09:17:10 +11:00
committed by GitHub
parent d857d704e3
commit 4651af5767
223 changed files with 1504 additions and 1752 deletions

View File

@@ -3,6 +3,7 @@ package engine
import (
"errors"
"fmt"
"slices"
"strings"
"sync/atomic"
"time"
@@ -147,7 +148,7 @@ func (m *eventManager) Remove(eventID int64) bool {
defer m.m.Unlock()
for i := range m.events {
if m.events[i].ID == eventID {
m.events = append(m.events[:i], m.events[i+1:]...)
m.events = slices.Delete(m.events, i, i+1)
return true
}
}