modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID

backtester/engine/backtest_test.go

@@ -92,7 +92,7 @@ func TestSetupFromConfig(t *testing.T) {
 
 	cfg.StrategySettings = config.StrategySettings{
 		Name: dollarcostaverage.Name,
-		CustomSettings: map[string]interface{}{
+		CustomSettings: map[string]any{
 			"hello": "moto",
 		},
 	}
@@ -166,7 +166,7 @@ func TestLoadDataAPI(t *testing.T) {
 		},
 		StrategySettings: config.StrategySettings{
 			Name: dollarcostaverage.Name,
-			CustomSettings: map[string]interface{}{
+			CustomSettings: map[string]any{
 				"hello": "moto",
 			},
 		},
@@ -222,7 +222,7 @@ func TestLoadDataCSV(t *testing.T) {
 		},
 		StrategySettings: config.StrategySettings{
 			Name: dollarcostaverage.Name,
-			CustomSettings: map[string]interface{}{
+			CustomSettings: map[string]any{
 				"hello": "moto",
 			},
 		},
@@ -289,7 +289,7 @@ func TestLoadDataDatabase(t *testing.T) {
 		},
 		StrategySettings: config.StrategySettings{
 			Name: dollarcostaverage.Name,
-			CustomSettings: map[string]interface{}{
+			CustomSettings: map[string]any{
 				"hello": "moto",
 			},
 		},
@@ -367,7 +367,7 @@ func TestLoadDataLive(t *testing.T) {
 		},
 		StrategySettings: config.StrategySettings{
 			Name: dollarcostaverage.Name,
-			CustomSettings: map[string]interface{}{
+			CustomSettings: map[string]any{
 				"hello": "moto",
 			},
 		},