d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-02 15:10:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

modernise: Run new gopls modernise tool against the codebase and fix minor issues (#1826)

Browse Source 
* modernise: Run new gopls modernise tool against codebase

* Address shazbert's nits

* apichecker, gctcli: Simplify HTML scraping functions and improve depth limit handling

* refactor: Create minSyncInterval const and update order book limit handling for binance and binanceUS

* refactor: Various slice usage improvements and rename TODO

* tranches: Revert deleteByID changes due to performance decrease

Shazbert was a F1 driver in a past lifetime 🏎️

* tranches: Simply retrieve copy

Thanks to shazbert

* documentation: Sort contributors list by contributions

* tranches: Remove deadcode in deleteByID
This commit is contained in:
Adrian Gallagher
2025-03-21 09:17:10 +11:00
committed by GitHub
parent d857d704e3
commit 4651af5767
223 changed files with 1504 additions and 1752 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
backtester/engine/backtest_test.go
View File

@@ -92,7 +92,7 @@ func TestSetupFromConfig(t *testing.T) {
cfg.StrategySettings = config.StrategySettings{
Name: dollarcostaverage.Name,
CustomSettings: map[string]interface{}{
CustomSettings: map[string]any{
"hello": "moto",
},
}
@@ -166,7 +166,7 @@ func TestLoadDataAPI(t *testing.T) {
},
StrategySettings: config.StrategySettings{
Name: dollarcostaverage.Name,
CustomSettings: map[string]interface{}{
CustomSettings: map[string]any{
"hello": "moto",
},
},
@@ -222,7 +222,7 @@ func TestLoadDataCSV(t *testing.T) {
},
StrategySettings: config.StrategySettings{
Name: dollarcostaverage.Name,
CustomSettings: map[string]interface{}{
CustomSettings: map[string]any{
"hello": "moto",
},
},
@@ -289,7 +289,7 @@ func TestLoadDataDatabase(t *testing.T) {
},
StrategySettings: config.StrategySettings{
Name: dollarcostaverage.Name,
CustomSettings: map[string]interface{}{
CustomSettings: map[string]any{
"hello": "moto",
},
},
@@ -367,7 +367,7 @@ func TestLoadDataLive(t *testing.T) {
},
StrategySettings: config.StrategySettings{
Name: dollarcostaverage.Name,
CustomSettings: map[string]interface{}{
CustomSettings: map[string]any{
"hello": "moto",
},
},

2
backtester/engine/fakeinterfaces_test.go
View File

@@ -307,7 +307,7 @@ func (f fakeStrat) SupportsSimultaneousProcessing() bool {
func (f fakeStrat) SetSimultaneousProcessing(bool) {}
func (f fakeStrat) SetCustomSettings(map[string]interface{}) error {
func (f fakeStrat) SetCustomSettings(map[string]any) error {
return nil
}

2
backtester/engine/grpcserver.go
View File

@@ -358,7 +358,7 @@ func (s *GRPCServer) ExecuteStrategyFromConfig(_ context.Context, request *btrpc
}
}
customSettings := make(map[string]interface{}, len(request.Config.StrategySettings.CustomSettings))
customSettings := make(map[string]any, len(request.Config.StrategySettings.CustomSettings))
for i := range request.Config.StrategySettings.CustomSettings {
customSettings[request.Config.StrategySettings.CustomSettings[i].KeyField] = request.Config.StrategySettings.CustomSettings[i].KeyValue
}

5
backtester/engine/taskmanager.go
View File

@@ -3,6 +3,7 @@ package engine
import (
"errors"
"fmt"
"slices"
"github.com/gofrs/uuid"
gctcommon "github.com/thrasher-corp/gocryptotrader/common"
@@ -185,7 +186,7 @@ func (r *TaskManager) ClearTask(id uuid.UUID) error {
if r.tasks[i].IsRunning() {
return fmt.Errorf("%w %v, currently running. Stop it first", errCannotClear, r.tasks[i].MetaData.ID)
}
r.tasks = append(r.tasks[:i], r.tasks[i+1:]...)
r.tasks = slices.Delete(r.tasks, i, i+1)
return nil
}
return fmt.Errorf("%s %w", id, errTaskNotFound)
@@ -208,7 +209,7 @@ func (r *TaskManager) ClearAllTasks() (clearedRuns, remainingRuns []*TaskSummary
remainingRuns = append(remainingRuns, run)
} else {
clearedRuns = append(clearedRuns, run)
r.tasks = append(r.tasks[:i], r.tasks[i+1:]...)
r.tasks = slices.Delete(r.tasks, i, i+1)
i--
}
}