From 45652564f48fd34a47468a09dfb29e7715d2cc5f Mon Sep 17 00:00:00 2001 From: Ryan O'Hara-Reid Date: Mon, 10 Feb 2025 13:54:02 +1100 Subject: [PATCH] orderbook: fix fields not being retrieved when getting orderbook.Base (#1793) * orderbook: fix fields not being retrieved * glorious: nits --------- Co-authored-by: shazbert --- exchanges/orderbook/depth.go | 2 ++ exchanges/orderbook/depth_test.go | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/exchanges/orderbook/depth.go b/exchanges/orderbook/depth.go index d97b8cea..2a35b5fb 100644 --- a/exchanges/orderbook/depth.go +++ b/exchanges/orderbook/depth.go @@ -84,6 +84,8 @@ func (d *Depth) Retrieve() (*Base, error) { VerifyOrderbook: d.verifyOrderbook, MaxDepth: d.maxDepth, ChecksumStringRequired: d.checksumStringRequired, + RestSnapshot: d.restSnapshot, + IDAlignment: d.idAligned, }, nil } diff --git a/exchanges/orderbook/depth_test.go b/exchanges/orderbook/depth_test.go index da96ef1b..9efb9cf4 100644 --- a/exchanges/orderbook/depth_test.go +++ b/exchanges/orderbook/depth_test.go @@ -96,7 +96,20 @@ func TestRetrieve(t *testing.T) { assert.NoError(t, err, "Retrieve should not error") assert.Len(t, ob.Asks, 1, "Should have correct Asks") assert.Len(t, ob.Bids, 1, "Should have correct Bids") + assert.Equal(t, "THE BIG ONE!!!!!!", ob.Exchange, "Should have correct Exchange") + assert.Equal(t, currency.NewPair(currency.THETA, currency.USD), ob.Pair, "Should have correct Pair") + assert.Equal(t, asset.DownsideProfitContract, ob.Asset, "Should have correct Asset") + assert.Equal(t, d.options.lastUpdated, ob.LastUpdated, "Should have correct LastUpdated") + assert.Equal(t, d.options.updatePushedAt, ob.UpdatePushedAt, "Should have correct UpdatePushedAt") + assert.Equal(t, d.options.insertedAt, ob.InsertedAt, "Should have correct InsertedAt") + assert.EqualValues(t, 1337, ob.LastUpdateID, "Should have correct LastUpdateID") + assert.True(t, ob.PriceDuplication, "Should have correct PriceDuplication") + assert.True(t, ob.IsFundingRate, "Should have correct IsFundingRate") + assert.True(t, ob.VerifyOrderbook, "Should have correct VerifyOrderbook") + assert.True(t, ob.RestSnapshot, "Should have correct RestSnapshot") + assert.True(t, ob.IDAlignment, "Should have correct IDAligned") assert.Equal(t, 10, ob.MaxDepth, "Should have correct MaxDepth") + assert.True(t, ob.ChecksumStringRequired, "Should have correct ChecksumStringRequired") } func TestTotalAmounts(t *testing.T) {