d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-01 07:26:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use currency.NewBTCUSD and NewBTCUSDT (#1895)

Browse Source 
* Tests: Use currency.NewUSD and NewUSDT

Simple refactor to use the provided shortcut methods

* Github: Add CI check to ensure NewPair not used

Add a step to ensure NewPair(BTC, USD*) isn't used
This commit is contained in:
Gareth Kirwan
2025-05-07 03:32:06 +02:00
committed by GitHub
parent eda6015d73
commit 3caa149d8e
83 changed files with 555 additions and 542 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
exchanges/kline/kline_test.go
View File

@@ -90,7 +90,7 @@ func TestValidateData(t *testing.T) {
func TestCreateKline(t *testing.T) {
t.Parallel()
pair := currency.NewPair(currency.BTC, currency.USD)
pair := currency.NewBTCUSD()
_, err := CreateKline(nil, OneMin, pair, asset.Spot, "Binance")
if !errors.Is(err, errInsufficientTradeData) {
t.Fatalf("received: '%v' but expected '%v'", err, errInsufficientTradeData)
@@ -459,7 +459,7 @@ func TestItem_SortCandlesByTimestamp(t *testing.T) {
t.Parallel()
tempKline := Item{
Exchange: "testExchange",
Pair: currency.NewPair(currency.BTC, currency.USDT),
Pair: currency.NewBTCUSDT(),
Asset: asset.Spot,
Interval: OneDay,
}
@@ -699,7 +699,7 @@ func genOHCLVData() (out candle.Item, outItem Item, err error) {
outItem.Interval = OneDay
outItem.Asset = asset.Spot
outItem.Pair = currency.NewPair(currency.BTC, currency.USDT)
outItem.Pair = currency.NewBTCUSDT()
outItem.Exchange = testExchanges[0].Name
for x := range 365 {
@@ -913,7 +913,7 @@ func TestConvertToNewInterval(t *testing.T) {
old := &Item{
Exchange: "lol",
Pair: currency.NewPair(currency.BTC, currency.USDT),
Pair: currency.NewBTCUSDT(),
Asset: asset.Spot,
Interval: OneDay,
Candles: []Candle{

8
exchanges/kline/request_test.go
View File

@@ -23,7 +23,7 @@ func TestCreateKlineRequest(t *testing.T) {
t.Fatalf("received: '%v', but expected '%v'", err, currency.ErrCurrencyPairEmpty)
}
pair := currency.NewPair(currency.BTC, currency.USDT)
pair := currency.NewBTCUSDT()
_, err = CreateKlineRequest("name", pair, currency.EMPTYPAIR, 0, 0, 0, time.Time{}, time.Time{}, 0)
if !errors.Is(err, currency.ErrCurrencyPairEmpty) {
t.Fatalf("received: '%v', but expected '%v'", err, currency.ErrCurrencyPairEmpty)
@@ -118,7 +118,7 @@ func TestGetRanges(t *testing.T) {
start := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
end := start.AddDate(0, 0, 1)
pair := currency.NewPair(currency.BTC, currency.USDT)
pair := currency.NewBTCUSDT()
var r *Request
_, err := r.GetRanges(100)
@@ -198,7 +198,7 @@ func TestRequest_ProcessResponse(t *testing.T) {
start := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)
end := start.AddDate(0, 0, 1)
pair := currency.NewPair(currency.BTC, currency.USDT)
pair := currency.NewBTCUSDT()
var r *Request
_, err := r.ProcessResponse(nil)
@@ -333,7 +333,7 @@ func TestExtendedRequest_ProcessResponse(t *testing.T) {
ohc := getOneHour()
start := ohc[0].Time
end := ohc[len(ohc)-1].Time.Add(OneHour.Duration())
pair := currency.NewPair(currency.BTC, currency.USDT)
pair := currency.NewBTCUSDT()
var rExt *ExtendedRequest
_, err := rExt.ProcessResponse(nil)