d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-03 15:10:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use currency.NewBTCUSD and NewBTCUSDT (#1895)

Browse Source 
* Tests: Use currency.NewUSD and NewUSDT

Simple refactor to use the provided shortcut methods

* Github: Add CI check to ensure NewPair not used

Add a step to ensure NewPair(BTC, USD*) isn't used
This commit is contained in:
Gareth Kirwan
2025-05-07 03:32:06 +02:00
committed by GitHub
parent eda6015d73
commit 3caa149d8e
83 changed files with 555 additions and 542 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
engine/order_manager_test.go
View File

@@ -29,7 +29,7 @@ type omfExchange struct {
exchange.IBotExchange
}
var btcusdPair = currency.NewPair(currency.BTC, currency.USD)
var btcusdPair = currency.NewBTCUSD()
// CancelOrder overrides testExchange's cancel order function
// to do the bare minimum required with no API calls or credentials required
@@ -1160,7 +1160,7 @@ func Test_getActiveOrders(t *testing.T) {
func TestGetFuturesPositionsForExchange(t *testing.T) {
t.Parallel()
o := &OrderManager{}
cp := currency.NewPair(currency.BTC, currency.USDT)
cp := currency.NewBTCUSDT()
_, err := o.GetFuturesPositionsForExchange("test", asset.Spot, cp)
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("received '%v', expected '%v'", err, ErrSubSystemNotStarted)
@@ -1208,7 +1208,7 @@ func TestGetFuturesPositionsForExchange(t *testing.T) {
func TestClearFuturesPositionsForExchange(t *testing.T) {
t.Parallel()
o := &OrderManager{}
cp := currency.NewPair(currency.BTC, currency.USDT)
cp := currency.NewBTCUSDT()
err := o.ClearFuturesTracking("test", asset.Spot, cp)
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("received '%v', expected '%v'", err, ErrSubSystemNotStarted)
@@ -1260,7 +1260,7 @@ func TestClearFuturesPositionsForExchange(t *testing.T) {
func TestUpdateOpenPositionUnrealisedPNL(t *testing.T) {
t.Parallel()
o := &OrderManager{}
cp := currency.NewPair(currency.BTC, currency.USDT)
cp := currency.NewBTCUSDT()
_, err := o.UpdateOpenPositionUnrealisedPNL("test", asset.Spot, cp, 1, time.Now())
if !errors.Is(err, ErrSubSystemNotStarted) {
t.Errorf("received '%v', expected '%v'", err, ErrSubSystemNotStarted)
@@ -1395,7 +1395,7 @@ func TestUpdateExisting(t *testing.T) {
od.Exchange = testExchange
od.AssetType = asset.Futures
od.OrderID = "123"
od.Pair = currency.NewPair(currency.BTC, currency.USDT)
od.Pair = currency.NewBTCUSDT()
od.Side = order.Buy
od.Type = order.Market
od.Date = time.Now()