d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-06 07:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use currency.NewBTCUSD and NewBTCUSDT (#1895)

Browse Source 
* Tests: Use currency.NewUSD and NewUSDT

Simple refactor to use the provided shortcut methods

* Github: Add CI check to ensure NewPair not used

Add a step to ensure NewPair(BTC, USD*) isn't used
This commit is contained in:
Gareth Kirwan
2025-05-07 03:32:06 +02:00
committed by GitHub
parent eda6015d73
commit 3caa149d8e
83 changed files with 555 additions and 542 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
engine/helpers_test.go
View File

@@ -42,8 +42,8 @@ var testExchange = "Bitstamp"
func CreateTestBot(tb testing.TB) *Engine {
tb.Helper()
cFormat := &currency.PairFormat{Uppercase: true}
cp1 := currency.NewPair(currency.BTC, currency.USD)
cp2 := currency.NewPair(currency.BTC, currency.USDT)
cp1 := currency.NewBTCUSD()
cp2 := currency.NewBTCUSDT()
pairs1 := map[asset.Item]*currency.PairStore{
asset.Spot: {
@@ -377,8 +377,8 @@ func TestGetSpecificAvailablePairs(t *testing.T) {
CurrencyPairs: &currency.PairsManager{Pairs: map[asset.Item]*currency.PairStore{
asset.Spot: {
AssetEnabled: true,
Enabled: currency.Pairs{currency.NewPair(currency.BTC, currency.USD), currency.NewPair(currency.BTC, c)},
Available: currency.Pairs{currency.NewPair(currency.BTC, currency.USD), currency.NewPair(currency.BTC, c)},
Enabled: currency.Pairs{currency.NewBTCUSD(), currency.NewPair(currency.BTC, c)},
Available: currency.Pairs{currency.NewBTCUSD(), currency.NewPair(currency.BTC, c)},
ConfigFormat: &currency.PairFormat{
Uppercase: true,
},
@@ -390,7 +390,7 @@ func TestGetSpecificAvailablePairs(t *testing.T) {
assetType := asset.Spot
result := e.GetSpecificAvailablePairs(true, true, true, true, assetType)
btcUSD := currency.NewPair(currency.BTC, currency.USD)
btcUSD := currency.NewBTCUSD()
if !result.Contains(btcUSD, true) {
t.Error("Unexpected result")
}
@@ -682,7 +682,7 @@ func TestMapCurrenciesByExchange(t *testing.T) {
e := CreateTestBot(t)
pairs := []currency.Pair{
currency.NewPair(currency.BTC, currency.USD),
currency.NewBTCUSD(),
currency.NewPair(currency.BTC, currency.EUR),
}
@@ -956,11 +956,11 @@ func createDepositEngine(opts *fakeDepositExchangeOpts) *Engine {
ps := currency.PairStore{
AssetEnabled: true,
Enabled: currency.Pairs{
currency.NewPair(currency.BTC, currency.USDT),
currency.NewBTCUSDT(),
currency.NewPair(currency.XRP, currency.USDT),
},
Available: currency.Pairs{
currency.NewPair(currency.BTC, currency.USDT),
currency.NewBTCUSDT(),
currency.NewPair(currency.XRP, currency.USDT),
},
}