From 29f7faea5425e3006f770c53171623504f93e18b Mon Sep 17 00:00:00 2001 From: Vazha Date: Thu, 7 Jan 2021 07:33:27 +0200 Subject: [PATCH] Binance: GetOrderInfo method issue. Kraken - add Cost param to GetOrderInfo output (#615) * add Cost param to Kraken GetOrderInfo output * fmt * faulty resp.Time handling in Binance GetOrderInfo method Co-authored-by: Vazha Bezhanishvili --- exchanges/binance/binance_wrapper.go | 6 +----- exchanges/kraken/kraken_wrapper.go | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/exchanges/binance/binance_wrapper.go b/exchanges/binance/binance_wrapper.go index 42e269af..7e403413 100644 --- a/exchanges/binance/binance_wrapper.go +++ b/exchanges/binance/binance_wrapper.go @@ -710,10 +710,6 @@ func (b *Binance) GetOrderInfo(orderID string, pair currency.Pair, assetType ass } orderSide := order.Side(resp.Side) - orderDate, err := convert.TimeFromUnixTimestampFloat(resp.Time) - if err != nil { - return - } status, err := order.StringToOrderStatus(resp.Status) if err != nil { @@ -727,7 +723,7 @@ func (b *Binance) GetOrderInfo(orderID string, pair currency.Pair, assetType ass return order.Detail{ Amount: resp.OrigQty, - Date: orderDate, + Date: resp.Time, Exchange: b.Name, ID: strconv.FormatInt(resp.OrderID, 10), Side: orderSide, diff --git a/exchanges/kraken/kraken_wrapper.go b/exchanges/kraken/kraken_wrapper.go index 4d437ff5..aade1b2f 100644 --- a/exchanges/kraken/kraken_wrapper.go +++ b/exchanges/kraken/kraken_wrapper.go @@ -775,6 +775,7 @@ func (k *Kraken) GetOrderInfo(orderID string, pair currency.Pair, assetType asse RemainingAmount: orderInfo.Volume - orderInfo.VolumeExecuted, Fee: orderInfo.Fee, Trades: trades, + Cost: orderInfo.Cost, } return orderDetail, nil