d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-08 23:16:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Makefile: add new recipes and linter features (#244)

Browse Source 
* Makefile: add new recipes and linter features

* expand linter coverage and fix issues

* Update makefile

* address PR nitterinos
This commit is contained in:
Adrian Gallagher
2019-01-31 14:53:24 +11:00
committed by GitHub
parent e182248387
commit 291e404a4a
85 changed files with 306 additions and 393 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
exchanges/bitflyer/bitflyer.go
View File

@@ -386,7 +386,7 @@ func (b *Bitflyer) SendHTTPRequest(path string, result interface{}) error {
func (b *Bitflyer) SendAuthHTTPRequest(path string, params url.Values, result interface{}) {
headers := make(map[string]string)
headers["ACCESS-KEY"] = b.APIKey
headers["ACCESS-TIMESTAMP"] = strconv.FormatInt(int64(time.Now().UnixNano()), 10)
headers["ACCESS-TIMESTAMP"] = strconv.FormatInt(time.Now().UnixNano(), 10)
}
// GetFee returns an estimate of fee based on type of transaction
@@ -398,7 +398,7 @@ func (b *Bitflyer) GetFee(feeBuilder exchange.FeeBuilder) (float64, error) {
case exchange.CryptocurrencyTradeFee:
fee = calculateTradingFee(feeBuilder.PurchasePrice, feeBuilder.Amount)
case exchange.InternationalBankDepositFee:
fee = getDepositFee(feeBuilder.BankTransactionType, feeBuilder.CurrencyItem, feeBuilder.Amount)
fee = getDepositFee(feeBuilder.BankTransactionType, feeBuilder.CurrencyItem)
case exchange.InternationalBankWithdrawalFee:
fee = getWithdrawalFee(feeBuilder.BankTransactionType, feeBuilder.CurrencyItem, feeBuilder.Amount)
}
@@ -415,7 +415,7 @@ func calculateTradingFee(purchasePrice float64, amount float64) float64 {
return fee * amount * purchasePrice
}
func getDepositFee(bankTransactionType exchange.InternationalBankTransactionType, currency string, amount float64) (fee float64) {
func getDepositFee(bankTransactionType exchange.InternationalBankTransactionType, currency string) (fee float64) {
switch bankTransactionType {
case exchange.WireTransfer:
switch currency {

12
exchanges/bitflyer/bitflyer_test.go
View File

@@ -274,7 +274,7 @@ func TestSubmitOrder(t *testing.T) {
}
_, err := b.SubmitOrder(p, exchange.Buy, exchange.Market, 1, 1, "clientId")
if err != common.ErrNotYetImplemented {
t.Errorf("Expected 'Not Yet Implemented', recieved %v", err)
t.Errorf("Expected 'Not Yet Implemented', received %v", err)
}
}
@@ -299,7 +299,7 @@ func TestCancelExchangeOrder(t *testing.T) {
err := b.CancelOrder(orderCancellation)
// Assert
if err != common.ErrNotYetImplemented {
t.Errorf("Expected 'Not Yet Implemented', recieved %v", err)
t.Errorf("Expected 'Not Yet Implemented', received %v", err)
}
}
@@ -324,7 +324,7 @@ func TestCancelAllExchangeOrders(t *testing.T) {
_, err := b.CancelAllOrders(orderCancellation)
// Assert
if err != common.ErrNotYetImplemented {
t.Errorf("Expected 'Not Yet Implemented', recieved %v", err)
t.Errorf("Expected 'Not Yet Implemented', received %v", err)
}
}
@@ -344,7 +344,7 @@ func TestWithdraw(t *testing.T) {
_, err := b.WithdrawCryptocurrencyFunds(withdrawCryptoRequest)
if err != common.ErrNotYetImplemented {
t.Errorf("Expected 'Not Yet Implemented', recieved %v", err)
t.Errorf("Expected 'Not Yet Implemented', received %v", err)
}
}
@@ -367,7 +367,7 @@ func TestWithdrawFiat(t *testing.T) {
_, err := b.WithdrawFiatFunds(withdrawFiatRequest)
if err != common.ErrNotYetImplemented {
t.Errorf("Expected '%v', recieved: '%v'", common.ErrNotYetImplemented, err)
t.Errorf("Expected '%v', received: '%v'", common.ErrNotYetImplemented, err)
}
}
@@ -383,6 +383,6 @@ func TestWithdrawInternationalBank(t *testing.T) {
_, err := b.WithdrawFiatFundsToInternationalBank(withdrawFiatRequest)
if err != common.ErrNotYetImplemented {
t.Errorf("Expected '%v', recieved: '%v'", common.ErrNotYetImplemented, err)
t.Errorf("Expected '%v', received: '%v'", common.ErrNotYetImplemented, err)
}
}