requester: defer execution of request.Item generation in closure (#723)

* requester: defer execution of request.Item generation in closure.

* bithumb: fix issue

* coinut/itbit: fix linter issues

* binance: fix bug on recvWindow setting

* requester: standardize sendpayload + add readme update

* nonce: remove inc() function

* request: defer unlockiflocked

* binance: revert changes for open orders

* btcmarkets: defer auth generation functionality, rm context deadline as this will be created just before sending HTTP request.

* binance: move const to top

* exmo: remove debug output as its generated in the requester function

* ftx: defer auth functionality

* requester: move error to top

* bittrex: defer auth functionality

* bitmex: defer auth functionality and remove deadline as generation occurs after rate limiting.

* btse: defer auth functionality

* coinbasepro: defer auth functionality and removed context deadline as this is generated after rate limiting

* coinbene: defer auth functionality and remove context deadline as this is generated after rate limiting

* huobi: defer auth functionality and remove context deadline as this is generated after rate limiting

* huobi-futures: defer auth functionality and remove context deadline as this is generated after rate limiting

* kraken: defer auth functionality and remove context deadline as this is generated after rate limiting

* kraken: remove deadline protection for timestamp generation

* okgroup: defer auth functionality and remove context deadline as this is generated after rate limiting

* poloniex: defer auth functionality

* zb: defer auth functionality and remove context deadline as this is generated after rate limiting

* exchanges: clean up log output which are done and inspected in the requester package

* binance: fix path bug on every retry, rm timeout context as this is not needed

* coinbene: fix path bug on retry

* binance: consolidate functionality

* coinbene: fix linter issues

* poloniex: linter fix

* kraken: change add -> set

* bitstamp: fix path bug for retry

* BTSE: fix retry path bug

* coinbene: fix path bug whoopsie by me

* gateio: fix bug where on retry it does not reset reader

* localbitcoins: fix path bug on retry

* zb: change domain to land

* exchanges: make sure io.Reader is generated every request

* exchanges: move reader generation into function scope

* wrapper_issues: setup exchange manager

* engine: expand withdraw manager test

* engine: dont look for environment

* bitstamp: fix pathing bug (@thrasher-)

* engine/withdraw_manager: purge tests as this is covered in repository withdraw

exchanges/gemini/gemini.go

@@ -14,7 +14,6 @@ import (
 	"github.com/thrasher-corp/gocryptotrader/common/crypto"
 	exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
 	"github.com/thrasher-corp/gocryptotrader/exchanges/request"
-	"github.com/thrasher-corp/gocryptotrader/log"
 )
 
 const (
@@ -351,13 +350,18 @@ func (g *Gemini) SendHTTPRequest(ep exchange.URL, path string, result interface{
 	if err != nil {
 		return err
 	}
-	return g.SendPayload(context.Background(), &request.Item{
+
+	item := &request.Item{
 		Method:        http.MethodGet,
 		Path:          endpoint + path,
 		Result:        result,
 		Verbose:       g.Verbose,
 		HTTPDebugging: g.HTTPDebugging,
 		HTTPRecording: g.HTTPRecording,
+	}
+
+	return g.SendPayload(context.Background(), request.Unset, func() (*request.Item, error) {
+		return item, nil
 	})
 }
 
@@ -373,45 +377,42 @@ func (g *Gemini) SendAuthenticatedHTTPRequest(ep exchange.URL, method, path stri
 		return err
 	}
 
-	req := make(map[string]interface{})
-	req["request"] = fmt.Sprintf("/v%s/%s", geminiAPIVersion, path)
-	req["nonce"] = g.Requester.GetNonce(true).String()
+	return g.SendPayload(context.Background(), request.Auth, func() (*request.Item, error) {
+		req := make(map[string]interface{})
+		req["request"] = fmt.Sprintf("/v%s/%s", geminiAPIVersion, path)
+		req["nonce"] = g.Requester.GetNonce(true).String()
 
-	for key, value := range params {
-		req[key] = value
-	}
+		for key, value := range params {
+			req[key] = value
+		}
 
-	PayloadJSON, err := json.Marshal(req)
-	if err != nil {
-		return errors.New("sendAuthenticatedHTTPRequest: Unable to JSON request")
-	}
+		PayloadJSON, err := json.Marshal(req)
+		if err != nil {
+			return nil, err
+		}
 
-	if g.Verbose {
-		log.Debugf(log.ExchangeSys, "Request JSON: %s", PayloadJSON)
-	}
+		PayloadBase64 := crypto.Base64Encode(PayloadJSON)
+		hmac := crypto.GetHMAC(crypto.HashSHA512_384, []byte(PayloadBase64), []byte(g.API.Credentials.Secret))
 
-	PayloadBase64 := crypto.Base64Encode(PayloadJSON)
-	hmac := crypto.GetHMAC(crypto.HashSHA512_384, []byte(PayloadBase64), []byte(g.API.Credentials.Secret))
+		headers := make(map[string]string)
+		headers["Content-Length"] = "0"
+		headers["Content-Type"] = "text/plain"
+		headers["X-GEMINI-APIKEY"] = g.API.Credentials.Key
+		headers["X-GEMINI-PAYLOAD"] = PayloadBase64
+		headers["X-GEMINI-SIGNATURE"] = crypto.HexEncodeToString(hmac)
+		headers["Cache-Control"] = "no-cache"
 
-	headers := make(map[string]string)
-	headers["Content-Length"] = "0"
-	headers["Content-Type"] = "text/plain"
-	headers["X-GEMINI-APIKEY"] = g.API.Credentials.Key
-	headers["X-GEMINI-PAYLOAD"] = PayloadBase64
-	headers["X-GEMINI-SIGNATURE"] = crypto.HexEncodeToString(hmac)
-	headers["Cache-Control"] = "no-cache"
-
-	return g.SendPayload(context.Background(), &request.Item{
-		Method:        method,
-		Path:          endpoint + "/v1/" + path,
-		Headers:       headers,
-		Result:        result,
-		AuthRequest:   true,
-		NonceEnabled:  true,
-		Verbose:       g.Verbose,
-		HTTPDebugging: g.HTTPDebugging,
-		HTTPRecording: g.HTTPRecording,
-		Endpoint:      request.Auth,
+		return &request.Item{
+			Method:        method,
+			Path:          endpoint + "/v1/" + path,
+			Headers:       headers,
+			Result:        result,
+			AuthRequest:   true,
+			NonceEnabled:  true,
+			Verbose:       g.Verbose,
+			HTTPDebugging: g.HTTPDebugging,
+			HTTPRecording: g.HTTPRecording,
+		}, nil
 	})
 }