mirror of
https://github.com/d0zingcat/gocryptotrader.git
synced 2026-05-22 07:26:50 +00:00
requester: defer execution of request.Item generation in closure (#723)
* requester: defer execution of request.Item generation in closure. * bithumb: fix issue * coinut/itbit: fix linter issues * binance: fix bug on recvWindow setting * requester: standardize sendpayload + add readme update * nonce: remove inc() function * request: defer unlockiflocked * binance: revert changes for open orders * btcmarkets: defer auth generation functionality, rm context deadline as this will be created just before sending HTTP request. * binance: move const to top * exmo: remove debug output as its generated in the requester function * ftx: defer auth functionality * requester: move error to top * bittrex: defer auth functionality * bitmex: defer auth functionality and remove deadline as generation occurs after rate limiting. * btse: defer auth functionality * coinbasepro: defer auth functionality and removed context deadline as this is generated after rate limiting * coinbene: defer auth functionality and remove context deadline as this is generated after rate limiting * huobi: defer auth functionality and remove context deadline as this is generated after rate limiting * huobi-futures: defer auth functionality and remove context deadline as this is generated after rate limiting * kraken: defer auth functionality and remove context deadline as this is generated after rate limiting * kraken: remove deadline protection for timestamp generation * okgroup: defer auth functionality and remove context deadline as this is generated after rate limiting * poloniex: defer auth functionality * zb: defer auth functionality and remove context deadline as this is generated after rate limiting * exchanges: clean up log output which are done and inspected in the requester package * binance: fix path bug on every retry, rm timeout context as this is not needed * coinbene: fix path bug on retry * binance: consolidate functionality * coinbene: fix linter issues * poloniex: linter fix * kraken: change add -> set * bitstamp: fix path bug for retry * BTSE: fix retry path bug * coinbene: fix path bug whoopsie by me * gateio: fix bug where on retry it does not reset reader * localbitcoins: fix path bug on retry * zb: change domain to land * exchanges: make sure io.Reader is generated every request * exchanges: move reader generation into function scope * wrapper_issues: setup exchange manager * engine: expand withdraw manager test * engine: dont look for environment * bitstamp: fix pathing bug (@thrasher-) * engine/withdraw_manager: purge tests as this is covered in repository withdraw
This commit is contained in:
@@ -150,9 +150,19 @@ func TestWithdrawalEventByExchange(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
_, err = m.WithdrawalEventByExchange(exchangeName, 1)
|
||||
if err == nil {
|
||||
t.Error(err)
|
||||
|
||||
_, err = (*WithdrawManager)(nil).WithdrawalEventByExchange("xxx", 0)
|
||||
if !errors.Is(err, ErrNilSubsystem) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrNilSubsystem)
|
||||
}
|
||||
|
||||
_, err = m.WithdrawalEventByExchange("xxx", 0)
|
||||
if !errors.Is(err, ErrExchangeNotFound) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrExchangeNotFound)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -163,9 +173,19 @@ func TestWithdrawEventByDate(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
_, err = m.WithdrawEventByDate(exchangeName, time.Now(), time.Now(), 1)
|
||||
if err == nil {
|
||||
t.Error(err)
|
||||
|
||||
_, err = (*WithdrawManager)(nil).WithdrawEventByDate("xxx", time.Now(), time.Now(), 1)
|
||||
if !errors.Is(err, ErrNilSubsystem) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrNilSubsystem)
|
||||
}
|
||||
|
||||
_, err = m.WithdrawEventByDate("xxx", time.Now(), time.Now(), 1)
|
||||
if !errors.Is(err, ErrExchangeNotFound) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrExchangeNotFound)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -176,8 +196,18 @@ func TestWithdrawalEventByExchangeID(t *testing.T) {
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
_, err = m.WithdrawalEventByExchangeID(exchangeName, exchangeName)
|
||||
if err == nil {
|
||||
t.Error(err)
|
||||
|
||||
_, err = (*WithdrawManager)(nil).WithdrawalEventByExchangeID("xxx", "xxx")
|
||||
if !errors.Is(err, ErrNilSubsystem) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrNilSubsystem)
|
||||
}
|
||||
|
||||
_, err = m.WithdrawalEventByExchangeID("xxx", "xxx")
|
||||
if !errors.Is(err, ErrExchangeNotFound) {
|
||||
t.Errorf("received: %v but expected: %v",
|
||||
err,
|
||||
ErrExchangeNotFound)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user