Config: Refactor version packages (#1887)

* Config: Move config versions to separate pacakges

* Config: Move version tests to blackbox texts

* Config: Protect registerVersion from overflow

* Config: Protect against version already registered

config/versions/v6/v6.go

@@ -0,0 +1,29 @@
+package v6
+
+import (
+	"context"
+	"errors"
+
+	"github.com/buger/jsonparser"
+)
+
+// Version implements ConfigVersion
+type Version struct{}
+
+// UpgradeConfig checks and upgrades the portfolioAddresses.providers field
+func (*Version) UpgradeConfig(_ context.Context, e []byte) ([]byte, error) {
+	_, valueType, _, err := jsonparser.Get(e, "portfolioAddresses", "providers")
+	switch {
+	case errors.Is(err, jsonparser.KeyPathNotFoundError), valueType == jsonparser.Null:
+		return jsonparser.Set(e, DefaultConfig, "portfolioAddresses", "providers")
+	case err != nil:
+		return e, err
+	}
+	return e, nil
+}
+
+// DowngradeConfig removes the portfolioAddresses.providers field
+func (*Version) DowngradeConfig(_ context.Context, e []byte) ([]byte, error) {
+	e = jsonparser.Delete(e, "portfolioAddresses", "providers")
+	return e, nil
+}

config/versions/v6/v6_test.go

@@ -0,0 +1,41 @@
+package v6_test
+
+import (
+	"bytes"
+	"context"
+	"testing"
+
+	"github.com/buger/jsonparser"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	v6 "github.com/thrasher-corp/gocryptotrader/config/versions/v6"
+)
+
+func TestUpgradeConfig(t *testing.T) {
+	t.Parallel()
+
+	in := []byte(`
+{"portfolioAddresses":{"addresses":[{"Address":"1JCe8z4jJVNXSjohjM4i9Hh813dLCNx2Sy","CoinType":"BTC","Balance":0.00108832,"Description":"","WhiteListed":false,"ColdStorage":false,"SupportedExchanges":""}]}}
+	`)
+
+	r, err := new(v6.Version).UpgradeConfig(context.Background(), in)
+	require.NoError(t, err, "UpgradeConfig must not error")
+	require.True(t, bytes.Contains(r, v6.DefaultConfig))
+
+	r2, err := new(v6.Version).UpgradeConfig(context.Background(), r)
+	require.NoError(t, err, "UpgradeConfig must not error")
+	assert.Equal(t, r, r2, "UpgradeConfig should not affect an already upgraded config")
+}
+
+func TestDowngradeConfig(t *testing.T) {
+	t.Parallel()
+
+	in := []byte(`
+{"portfolioAddresses":{"addresses":[{"Address":"1JCe8z4jJVNXSjohjM4i9Hh813dLCNx2Sy","CoinType":"BTC","Balance":0.00108832,"Description":"","WhiteListed":false,"ColdStorage":false,"SupportedExchanges":""}],"providers":[{"name":"Ethplorer","enabled":true},{"name":"XRPScan","enabled":true},{"name":"CryptoID","enabled":false,"apiKey":"Key"}]}}
+`)
+
+	r, err := new(v6.Version).DowngradeConfig(context.Background(), in)
+	require.NoError(t, err, "DowngradeConfig must not error")
+	_, _, _, err = jsonparser.Get(r, "portfolioAddresses", "providers") //nolint:dogsled // Return values not needed
+	assert.ErrorIs(t, err, jsonparser.KeyPathNotFoundError, "providers should be removed")
+}