codebase: Replace !errors.Is(err, target) with testify (#1931)

* tests: Replace !errors.Is(err, target) with testify equivalents

* codebase: Manual !errors.Is(err, target) replacements

* typo: Replace errMisMatchedEvent with errMismatchedEvent

* tests: Enhance error messages for better output

* tests: Refactor error assertions in various test cases to use require and improve clarity

* misc linter: Fix assert should wording

* tests: Simplify assertions in TestCreateSignals for clarity and conciseness

* tests: Enhance assertion message in TestCreateSignals

exchanges/kline/technical_analysis_test.go

@@ -1,7 +1,6 @@
 package kline
 
 import (
-	"errors"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -19,38 +18,26 @@ func TestGetAverageTrueRange(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetAverageTrueRange(0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetAverageTrueRange(0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetAverageTrueRange(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.High = append(ohlc.High, 1337)
 	_, err = ohlc.GetAverageTrueRange(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Low = append(ohlc.Low, 1337)
 	_, err = ohlc.GetAverageTrueRange(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Close = append(ohlc.Close, 1337)
 	_, err = ohlc.GetAverageTrueRange(9)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetAverageTrueRange(1)
 	require.NoError(t, err)
@@ -65,36 +52,24 @@ func TestGetBollingerBands(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetBollingerBands(0, 0, 0, 5)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetBollingerBands(0, 0, 0, 5)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetBollingerBands(9, 0, 0, 5)
-	if !errors.Is(err, errInvalidDeviationMultiplier) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidDeviationMultiplier)
-	}
+	require.ErrorIs(t, err, errInvalidDeviationMultiplier)
 
 	_, err = ohlc.GetBollingerBands(9, 1, 0, 5)
-	if !errors.Is(err, errInvalidDeviationMultiplier) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidDeviationMultiplier)
-	}
+	require.ErrorIs(t, err, errInvalidDeviationMultiplier)
 
 	_, err = ohlc.GetBollingerBands(9, 1, 1, 5)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Close = append(ohlc.Close, 1337, 1337, 1337, 1337, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetBollingerBands(10, 1, 1, 5)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetBollingerBands(9, 1, 1, 5)
 	require.NoError(t, err)
@@ -109,48 +84,32 @@ func TestGetCorrelationCoefficient(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetCorrelationCoefficient(nil, 0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetCorrelationCoefficient(nil, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetCorrelationCoefficient(nil, 1)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetCorrelationCoefficient(nil, 2)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	_, err = ohlc.GetCorrelationCoefficient(&OHLC{}, 9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Close = append(ohlc.Close, 1337, 1337)
 
 	_, err = ohlc.GetCorrelationCoefficient(&OHLC{}, 9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	_, err = ohlc.GetCorrelationCoefficient(&OHLC{Close: []float64{1337}}, 2)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	ohlc.Close = append(ohlc.Close, 1337)
 	_, err = ohlc.GetCorrelationCoefficient(&OHLC{Close: []float64{1337, 1337}}, 2)
-	if !errors.Is(err, errInvalidDataSetLengths) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidDataSetLengths)
-	}
+	require.ErrorIs(t, err, errInvalidDataSetLengths)
 
 	_, err = ohlc.GetCorrelationCoefficient(&OHLC{Close: []float64{1337, 1337, 1337}}, 2)
 	require.NoError(t, err)
@@ -165,25 +124,17 @@ func TestGetSimpleMovingAverage(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetSimpleMovingAverage(nil, 0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetSimpleMovingAverage(nil, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetSimpleMovingAverage(nil, 9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	_, err = ohlc.GetSimpleMovingAverage([]float64{1337}, 9)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetSimpleMovingAverage([]float64{1337, 1337}, 2)
 	require.NoError(t, err)
@@ -198,25 +149,17 @@ func TestGetExponentialMovingAverage(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetExponentialMovingAverage(nil, 0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetExponentialMovingAverage(nil, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetExponentialMovingAverage(nil, 9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	_, err = ohlc.GetExponentialMovingAverage([]float64{1337}, 9)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetExponentialMovingAverage([]float64{1337, 1337, 1337}, 2)
 	require.NoError(t, err)
@@ -231,40 +174,26 @@ func TestGetMovingAverageConvergenceDivergence(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetMovingAverageConvergenceDivergence(nil, 0, 0, 0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetMovingAverageConvergenceDivergence(nil, 0, 0, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence(nil, 1, 0, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence(nil, 1, 1, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence(nil, 1, 2, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence(nil, 1, 2, 1)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence([]float64{1337}, 1, 2, 2)
-	if !errors.Is(err, errNotEnoughData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNotEnoughData)
-	}
+	require.ErrorIs(t, err, errNotEnoughData)
 
 	_, err = ohlc.GetMovingAverageConvergenceDivergence([]float64{1337, 1337, 1337, 1337, 1337, 1337, 1337, 1337}, 1, 2, 1)
 	require.NoError(t, err)
@@ -279,50 +208,34 @@ func TestGetMoneyFlowIndex(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetMoneyFlowIndex(0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetMoneyFlowIndex(0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMoneyFlowIndex(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.High = append(ohlc.High, 1337, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetMoneyFlowIndex(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Low = append(ohlc.Low, 1337, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetMoneyFlowIndex(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Close = append(ohlc.Close, 1337, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetMoneyFlowIndex(9)
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Volume = append(ohlc.Volume, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetMoneyFlowIndex(5)
-	if !errors.Is(err, errInvalidDataSetLengths) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidDataSetLengths)
-	}
+	require.ErrorIs(t, err, errInvalidDataSetLengths)
 
 	ohlc.Volume = append(ohlc.Volume, 1337)
 	_, err = ohlc.GetMoneyFlowIndex(6)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetMoneyFlowIndex(3)
 	require.NoError(t, err)
@@ -341,21 +254,15 @@ func TestGetOnBalanceVolume(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetOnBalanceVolume()
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetOnBalanceVolume()
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Close = append(ohlc.Close, 1337, 1337, 1337, 1337, 1337, 1337)
 	_, err = ohlc.GetOnBalanceVolume()
-	if !errors.Is(err, errNoData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNoData)
-	}
+	require.ErrorIs(t, err, errNoData)
 
 	ohlc.Volume = append(ohlc.Volume, 0.00000001)
 	_, err = ohlc.GetOnBalanceVolume()
@@ -371,25 +278,17 @@ func TestGetRelativeStrengthIndex(t *testing.T) {
 
 	var ohlc *OHLC
 	_, err := ohlc.GetRelativeStrengthIndex(nil, 0)
-	if !errors.Is(err, errNilOHLC) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNilOHLC)
-	}
+	require.ErrorIs(t, err, errNilOHLC)
 
 	ohlc = &OHLC{}
 	_, err = ohlc.GetRelativeStrengthIndex(nil, 0)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	_, err = ohlc.GetRelativeStrengthIndex(nil, 9)
-	if !errors.Is(err, errNotEnoughData) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errNotEnoughData)
-	}
+	require.ErrorIs(t, err, errNotEnoughData)
 
 	_, err = ohlc.GetRelativeStrengthIndex([]float64{1337, 1337, 1337}, 9)
-	if !errors.Is(err, errInvalidPeriod) {
-		t.Fatalf("received: '%v' but expected: '%v'", err, errInvalidPeriod)
-	}
+	require.ErrorIs(t, err, errInvalidPeriod)
 
 	wrap := Item{Candles: []Candle{{Close: 1337}, {Close: 1337}, {Close: 1337}}}
 	_, err = wrap.GetRelativeStrengthIndexOnClose(2)