d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-05-13 15:09:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

codebase: Replace !errors.Is(err, target) with testify (#1931)

Browse Source 
* tests: Replace !errors.Is(err, target) with testify equivalents

* codebase: Manual !errors.Is(err, target) replacements

* typo: Replace errMisMatchedEvent with errMismatchedEvent

* tests: Enhance error messages for better output

* tests: Refactor error assertions in various test cases to use require and improve clarity

* misc linter: Fix assert should wording

* tests: Simplify assertions in TestCreateSignals for clarity and conciseness

* tests: Enhance assertion message in TestCreateSignals
This commit is contained in:
Adrian Gallagher
2025-06-10 16:29:57 +10:00
committed by GitHub
parent 122ab2f849
commit 19b8957f3f
109 changed files with 2485 additions and 5670 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
engine/exchange_manager_test.go
View File

@@ -1,11 +1,11 @@
package engine
import (
"errors"
"fmt"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
exchange "github.com/thrasher-corp/gocryptotrader/exchanges"
"github.com/thrasher-corp/gocryptotrader/exchanges/bitfinex"
@@ -33,24 +33,20 @@ func TestExchangeManagerAdd(t *testing.T) {
t.Parallel()
var m *ExchangeManager
err := m.Add(nil)
if !errors.Is(err, ErrNilSubsystem) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrNilSubsystem)
}
require.ErrorIs(t, err, ErrNilSubsystem)
m = NewExchangeManager()
err = m.Add(nil)
if !errors.Is(err, errExchangeIsNil) {
t.Fatalf("received: '%v' but expected: '%v'", err, errExchangeIsNil)
}
require.ErrorIs(t, err, errExchangeIsNil)
b := new(bitfinex.Bitfinex)
b.SetDefaults()
err = m.Add(b)
require.NoError(t, err)
err = m.Add(b)
if !errors.Is(err, ErrExchangeAlreadyLoaded) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeAlreadyLoaded)
}
require.ErrorIs(t, err, ErrExchangeAlreadyLoaded)
exchanges, err := m.GetExchanges()
if err != nil {
t.Error("no exchange manager found")
@@ -64,9 +60,7 @@ func TestExchangeManagerGetExchanges(t *testing.T) {
t.Parallel()
var m *ExchangeManager
_, err := m.GetExchanges()
if !errors.Is(err, ErrNilSubsystem) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrNilSubsystem)
}
require.ErrorIs(t, err, ErrNilSubsystem)
m = NewExchangeManager()
exchanges, err := m.GetExchanges()
@@ -94,21 +88,15 @@ func TestExchangeManagerRemoveExchange(t *testing.T) {
t.Parallel()
var m *ExchangeManager
err := m.RemoveExchange("")
if !errors.Is(err, ErrNilSubsystem) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrNilSubsystem)
}
require.ErrorIs(t, err, ErrNilSubsystem)
m = NewExchangeManager()
err = m.RemoveExchange("")
if !errors.Is(err, ErrExchangeNameIsEmpty) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeNameIsEmpty)
}
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
err = m.RemoveExchange("Bitfinex")
if !errors.Is(err, ErrExchangeNotFound) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeNotFound)
}
require.ErrorIs(t, err, ErrExchangeNotFound)
b := new(bitfinex.Bitfinex)
b.SetDefaults()
@@ -116,9 +104,7 @@ func TestExchangeManagerRemoveExchange(t *testing.T) {
require.NoError(t, err)
err = m.RemoveExchange("Bitstamp")
if !errors.Is(err, ErrExchangeNotFound) {
t.Errorf("received: %v but expected: %v", err, ErrExchangeNotFound)
}
assert.ErrorIs(t, err, ErrExchangeNotFound)
err = m.RemoveExchange("BiTFiNeX")
require.NoError(t, err)
@@ -134,23 +120,17 @@ func TestExchangeManagerRemoveExchange(t *testing.T) {
require.NoError(t, err)
err = m.RemoveExchange("BiTFiNeX")
if !errors.Is(err, errExpectedTestError) {
t.Fatalf("received: '%v' but expected: '%v'", err, errExpectedTestError)
}
require.ErrorIs(t, err, errExpectedTestError)
}
func TestNewExchangeByName(t *testing.T) {
var m *ExchangeManager
_, err := m.NewExchangeByName("")
if !errors.Is(err, ErrNilSubsystem) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrNilSubsystem)
}
require.ErrorIs(t, err, ErrNilSubsystem)
m = NewExchangeManager()
_, err = m.NewExchangeByName("")
if !errors.Is(err, ErrExchangeNameIsEmpty) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeNameIsEmpty)
}
require.ErrorIs(t, err, ErrExchangeNameIsEmpty)
exchanges := exchange.Exchanges
exchanges = append(exchanges, "fake")
@@ -175,9 +155,7 @@ func TestNewExchangeByName(t *testing.T) {
require.NoError(t, err)
_, err = m.NewExchangeByName("bitfinex")
if !errors.Is(err, ErrExchangeAlreadyLoaded) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrExchangeAlreadyLoaded)
}
require.ErrorIs(t, err, ErrExchangeAlreadyLoaded)
}
type ExchangeBuilder struct{}
@@ -215,9 +193,7 @@ func TestExchangeManagerShutdown(t *testing.T) {
t.Parallel()
var m *ExchangeManager
err := m.Shutdown(-1)
if !errors.Is(err, ErrNilSubsystem) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrNilSubsystem)
}
require.ErrorIs(t, err, ErrNilSubsystem)
m = NewExchangeManager()
err = m.Shutdown(-1)