codebase: Replace !errors.Is(err, target) with testify (#1931)

* tests: Replace !errors.Is(err, target) with testify equivalents

* codebase: Manual !errors.Is(err, target) replacements

* typo: Replace errMisMatchedEvent with errMismatchedEvent

* tests: Enhance error messages for better output

* tests: Refactor error assertions in various test cases to use require and improve clarity

* misc linter: Fix assert should wording

* tests: Simplify assertions in TestCreateSignals for clarity and conciseness

* tests: Enhance assertion message in TestCreateSignals
This commit is contained in:
Adrian Gallagher
2025-06-10 16:29:57 +10:00
committed by GitHub
parent 122ab2f849
commit 19b8957f3f
109 changed files with 2485 additions and 5670 deletions

View File

@@ -1,7 +1,6 @@
package currency
import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
@@ -253,9 +252,7 @@ func TestBaseCode(t *testing.T) {
Symbol: "BTC",
ID: 1337,
})
if !errors.Is(err, errRoleUnset) {
t.Fatalf("received: '%v' but expected: '%v'", err, errRoleUnset)
}
require.ErrorIs(t, err, errRoleUnset)
err = main.UpdateCurrency(&Item{
FullName: "Bitcoin",
@@ -331,14 +328,10 @@ func TestBaseCode(t *testing.T) {
}
err = main.LoadItem(nil)
if !errors.Is(err, errItemIsNil) {
t.Fatalf("received: '%v' but expected: '%v'", err, errItemIsNil)
}
require.ErrorIs(t, err, errItemIsNil)
err = main.LoadItem(&Item{})
if !errors.Is(err, errItemIsEmpty) {
t.Fatalf("received: '%v' but expected: '%v'", err, errItemIsEmpty)
}
require.ErrorIs(t, err, errItemIsEmpty)
err = main.LoadItem(&Item{
ID: 0,