d0zingcat/gocryptotrader
1
0
Fork 0
mirror of https://github.com/d0zingcat/gocryptotrader.git synced 2026-06-07 15:11:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

codebase: Replace !errors.Is(err, target) with testify (#1931)

Browse Source 
* tests: Replace !errors.Is(err, target) with testify equivalents

* codebase: Manual !errors.Is(err, target) replacements

* typo: Replace errMisMatchedEvent with errMismatchedEvent

* tests: Enhance error messages for better output

* tests: Refactor error assertions in various test cases to use require and improve clarity

* misc linter: Fix assert should wording

* tests: Simplify assertions in TestCreateSignals for clarity and conciseness

* tests: Enhance assertion message in TestCreateSignals
This commit is contained in:
Adrian Gallagher
2025-06-10 16:29:57 +10:00
committed by GitHub
parent 122ab2f849
commit 19b8957f3f
109 changed files with 2485 additions and 5670 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
common/common_test.go
View File

@@ -81,9 +81,7 @@ func TestSendHTTPRequest(t *testing.T) {
func TestSetHTTPClientWithTimeout(t *testing.T) {
t.Parallel()
err := SetHTTPClientWithTimeout(-0)
if !errors.Is(err, errCannotSetInvalidTimeout) {
t.Fatalf("received: %v but expected: %v", err, errCannotSetInvalidTimeout)
}
require.ErrorIs(t, err, errCannotSetInvalidTimeout)
err = SetHTTPClientWithTimeout(time.Second * 15)
require.NoError(t, err)
@@ -92,9 +90,7 @@ func TestSetHTTPClientWithTimeout(t *testing.T) {
func TestSetHTTPUserAgent(t *testing.T) {
t.Parallel()
err := SetHTTPUserAgent("")
if !errors.Is(err, errUserAgentInvalid) {
t.Fatalf("received: %v but expected: %v", err, errUserAgentInvalid)
}
require.ErrorIs(t, err, errUserAgentInvalid)
err = SetHTTPUserAgent("testy test")
require.NoError(t, err)
@@ -103,9 +99,7 @@ func TestSetHTTPUserAgent(t *testing.T) {
func TestSetHTTPClient(t *testing.T) {
t.Parallel()
err := SetHTTPClient(nil)
if !errors.Is(err, errHTTPClientInvalid) {
t.Fatalf("received: %v but expected: %v", err, errHTTPClientInvalid)
}
require.ErrorIs(t, err, errHTTPClientInvalid)
err = SetHTTPClient(new(http.Client))
require.NoError(t, err)
@@ -497,39 +491,25 @@ func TestParseStartEndDate(t *testing.T) {
nt := time.Time{}
err := StartEndTimeCheck(nt, nt)
if !errors.Is(err, ErrDateUnset) {
t.Errorf("received %v, expected %v", err, ErrDateUnset)
}
assert.ErrorIs(t, err, ErrDateUnset)
err = StartEndTimeCheck(et, nt)
if !errors.Is(err, ErrDateUnset) {
t.Errorf("received %v, expected %v", err, ErrDateUnset)
}
assert.ErrorIs(t, err, ErrDateUnset)
err = StartEndTimeCheck(et, zeroValueUnix)
if !errors.Is(err, ErrDateUnset) {
t.Errorf("received %v, expected %v", err, ErrDateUnset)
}
assert.ErrorIs(t, err, ErrDateUnset)
err = StartEndTimeCheck(zeroValueUnix, et)
if !errors.Is(err, ErrDateUnset) {
t.Errorf("received %v, expected %v", err, ErrDateUnset)
}
assert.ErrorIs(t, err, ErrDateUnset)
err = StartEndTimeCheck(et, et)
if !errors.Is(err, ErrStartEqualsEnd) {
t.Errorf("received %v, expected %v", err, ErrStartEqualsEnd)
}
assert.ErrorIs(t, err, ErrStartEqualsEnd)
err = StartEndTimeCheck(et, pt)
if !errors.Is(err, ErrStartAfterEnd) {
t.Errorf("received %v, expected %v", err, ErrStartAfterEnd)
}
assert.ErrorIs(t, err, ErrStartAfterEnd)
err = StartEndTimeCheck(ft, ft.Add(time.Hour))
if !errors.Is(err, ErrStartAfterTimeNow) {
t.Errorf("received %v, expected %v", err, ErrStartAfterTimeNow)
}
assert.ErrorIs(t, err, ErrStartAfterTimeNow)
err = StartEndTimeCheck(pt, et)
assert.NoError(t, err)
@@ -547,9 +527,7 @@ func TestGetAssertError(t *testing.T) {
}
err = GetTypeAssertError("bruh", struct{}{})
if !errors.Is(err, ErrTypeAssertFailure) {
t.Fatalf("received: '%v' but expected: '%v'", err, ErrTypeAssertFailure)
}
require.ErrorIs(t, err, ErrTypeAssertFailure)
err = GetTypeAssertError("string", struct{}{})
if err.Error() != "type assert failure from struct {} to string" {