codebase: Replace !errors.Is(err, target) with testify (#1931)

* tests: Replace !errors.Is(err, target) with testify equivalents

* codebase: Manual !errors.Is(err, target) replacements

* typo: Replace errMisMatchedEvent with errMismatchedEvent

* tests: Enhance error messages for better output

* tests: Refactor error assertions in various test cases to use require and improve clarity

* misc linter: Fix assert should wording

* tests: Simplify assertions in TestCreateSignals for clarity and conciseness

* tests: Enhance assertion message in TestCreateSignals
This commit is contained in:
Adrian Gallagher
2025-06-10 16:29:57 +10:00
committed by GitHub
parent 122ab2f849
commit 19b8957f3f
109 changed files with 2485 additions and 5670 deletions

View File

@@ -1,7 +1,6 @@
package common
import (
"errors"
"fmt"
"testing"
@@ -220,19 +219,13 @@ func TestPurgeColours(t *testing.T) {
func TestGenerateFileName(t *testing.T) {
t.Parallel()
_, err := GenerateFileName("", "")
if !errors.Is(err, errCannotGenerateFileName) {
t.Errorf("received '%v' expected '%v'", err, errCannotGenerateFileName)
}
assert.ErrorIs(t, err, errCannotGenerateFileName)
_, err = GenerateFileName("hello", "")
if !errors.Is(err, errCannotGenerateFileName) {
t.Errorf("received '%v' expected '%v'", err, errCannotGenerateFileName)
}
assert.ErrorIs(t, err, errCannotGenerateFileName)
_, err = GenerateFileName("", "moto")
if !errors.Is(err, errCannotGenerateFileName) {
t.Errorf("received '%v' expected '%v'", err, errCannotGenerateFileName)
}
assert.ErrorIs(t, err, errCannotGenerateFileName)
_, err = GenerateFileName("hello", "moto")
assert.NoError(t, err)
@@ -248,7 +241,5 @@ func TestRegisterBacktesterSubLoggers(t *testing.T) {
assert.NoError(t, err)
err = RegisterBacktesterSubLoggers()
if !errors.Is(err, log.ErrSubLoggerAlreadyRegistered) {
t.Errorf("received '%v' expected '%v'", err, log.ErrSubLoggerAlreadyRegistered)
}
assert.ErrorIs(t, err, log.ErrSubLoggerAlreadyRegistered)
}