golangci-lint: Bump to v2.0.2 and fix issues (#1871)

* build(deps): Bump golangci/golangci-lint-action from 6 to 7

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v6...v7)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* golangci-lint: Bump to v2 and fix issues

* refactor: remove no longer need ifshort nolint directives, fix test grammar and improve for loop logic

* nits: update order pair handling in tests and improve string replacement logic

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adrian Gallagher <adrian.gallagher@thrasher.io>

common/common.go

@@ -588,7 +588,7 @@ func GenerateRandomString(length uint, characters ...string) (string, error) {
 		return "", errors.New("invalid length, length must be non-zero positive integer")
 	}
 	b := make([]byte, length)
-	chars := strings.Replace(strings.Join(characters, ""), " ", "", -1)
+	chars := strings.ReplaceAll(strings.Join(characters, ""), " ", "")
 	if chars == "" && len(characters) != 0 {
 		return "", errors.New("invalid characters, character must not be empty")
 	} else if chars == "" {