(Engine) Variety of engine updates (#390)

* drop common uuid v4 func and imported package as needed

* removed common functions regarding json marshal and unmarshal and used the json package directly. WRT unmarshal it was calling reflect and converted to string which is also checked in the JSON package so it was doing a double up, this will be a tiny gain as it was directly used in the requester package for all our outbound requests.

* add in string

* explicitly throw away return error value

* atleast return the error that websocket initialise returns

* return error when not connected

* fix comment

* Adds comments

* move package declarations

* drop append whenever we call supported

* remove unused import

* Change incorrect spelling

* fix tests

* fix go import issue

logger/logger_types.go

@@ -5,9 +5,31 @@ import (
 	"sync"
 )
 
-const timestampFormat = " 02/01/2006 15:04:05 "
+const (
+	timestampFormat = " 02/01/2006 15:04:05 "
+	spacer          = "|"
+)
 
-const spacer = "|"
+var (
+	logger = &Logger{}
+	// FileLoggingConfiguredCorrectly flag set during config check if file logging meets requirements
+	FileLoggingConfiguredCorrectly bool
+	// GlobalLogConfig holds global configuration options for logger
+	GlobalLogConfig = &Config{}
+	// GlobalLogFile hold global configuration options for file logger
+	GlobalLogFile = &Rotate{}
+
+	eventPool = &sync.Pool{
+		New: func() interface{} {
+			return &LogEvent{
+				data: make([]byte, 0, 80),
+			}
+		},
+	}
+
+	// LogPath system path to store log files in
+	LogPath string
+)
 
 // Config holds configuration settings loaded from bot config
 type Config struct {
@@ -72,24 +94,3 @@ type multiWriter struct {
 	writers []io.Writer
 	mu      sync.RWMutex
 }
-
-var (
-	logger = &Logger{}
-	// FileLoggingConfiguredCorrectly flag set during config check if file logging meets requirements
-	FileLoggingConfiguredCorrectly bool
-	// GlobalLogConfig holds global configuration options for logger
-	GlobalLogConfig = &Config{}
-	// GlobalLogFile hold global configuration options for file logger
-	GlobalLogFile = &Rotate{}
-
-	eventPool = &sync.Pool{
-		New: func() interface{} {
-			return &LogEvent{
-				data: make([]byte, 0, 80),
-			}
-		},
-	}
-
-	// LogPath system path to store log files in
-	LogPath string
-)